Parametrize Suggest polling strategy and delay. Also add a parameter

to disable results caching.

TESTS=OmniboxFieldTrialTest + manual tests.

BUG=420903

Review URL: https://codereview.chromium.org/645303003

Cr-Commit-Position: refs/heads/master@{#301413}

1 files changed, 32 insertions, 0 deletions

diff --git a/components/omnibox/omnibox_field_trial.cc b/components/omnibox/omnibox_field_trial.cc
index 62cd8ec..7ad2956 100644
--- a/components/omnibox/omnibox_field_trial.cc
+++ b/components/omnibox/omnibox_field_trial.cc
@@ -343,6 +343,28 @@ bool OmniboxFieldTrial::DisplayHintTextWhenPossible() {
       kDisplayHintTextWhenPossibleRule) == "true";
 }
 
+bool OmniboxFieldTrial::DisableResultsCaching() {
+  return variations::GetVariationParamValue(
+      kBundledExperimentFieldTrialName,
+      kDisableResultsCachingRule) == "true";
+}
+
+void OmniboxFieldTrial::GetSuggestPollingStrategy(bool* from_last_keystroke,
+                                                  int* polling_delay_ms) {
+  *from_last_keystroke = variations::GetVariationParamValue(
+      kBundledExperimentFieldTrialName,
+      kMeasureSuggestPollingDelayFromLastKeystrokeRule) == "true";
+
+  const std::string& polling_delay_string = variations::GetVariationParamValue(
+      kBundledExperimentFieldTrialName,
+      kSuggestPollingDelayMsRule);
+  if (polling_delay_string.empty() ||
+      !base::StringToInt(polling_delay_string, polling_delay_ms) ||
+      (*polling_delay_ms <= 0)) {
+    *polling_delay_ms = kDefaultMinimumTimeBetweenSuggestQueriesMs;
+  }
+}
+
 const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
     "OmniboxBundledExperimentV1";
 const char OmniboxFieldTrial::kShortcutsScoringMaxRelevanceRule[] =
@@ -362,6 +384,13 @@ const char OmniboxFieldTrial::kAddUWYTMatchEvenIfPromotedURLsRule[] =
     "AddUWYTMatchEvenIfPromotedURLs";
 const char OmniboxFieldTrial::kDisplayHintTextWhenPossibleRule[] =
     "DisplayHintTextWhenPossible";
+const char OmniboxFieldTrial::kDisableResultsCachingRule[] =
+    "DisableResultsCaching";
+const char
+OmniboxFieldTrial::kMeasureSuggestPollingDelayFromLastKeystrokeRule[] =
+    "MeasureSuggestPollingDelayFromLastKeystroke";
+const char OmniboxFieldTrial::kSuggestPollingDelayMsRule[] =
+    "SuggestPollingDelayMs";
 
 const char OmniboxFieldTrial::kHUPNewScoringEnabledParam[] =
     "HUPExperimentalScoringEnabled";
@@ -378,6 +407,9 @@ const char OmniboxFieldTrial::kHUPNewScoringVisitedCountHalfLifeTimeParam[] =
 const char OmniboxFieldTrial::kHUPNewScoringVisitedCountScoreBucketsParam[] =
     "VisitedCountScoreBuckets";
 
+// static
+int OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs = 100;
+
 // Background and implementation details:
 //
 // Each experiment group in any field trial can come with an optional set of