diff options
author | ruuda <ruuda@google.com> | 2015-12-07 10:38:28 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-07 18:39:18 +0000 |
commit | 1b0e57c4e23482bc6909c523d76efd3b0861d452 (patch) | |
tree | a4ccc7c954b7d557f90c27df83b55eb2c9063acb /components/policy/resources/policy_templates_sl.xtb | |
parent | da218471f007776d7ed87b7c99341b56949fdd05 (diff) | |
download | chromium_src-1b0e57c4e23482bc6909c523d76efd3b0861d452.zip chromium_src-1b0e57c4e23482bc6909c523d76efd3b0861d452.tar.gz chromium_src-1b0e57c4e23482bc6909c523d76efd3b0861d452.tar.bz2 |
[Tracing] Make StackFrameDeduplicator take a range
Previously, |StackFrameDeduplicator::Insert| took a |Backtrace| which
contains a fixed size array. Taking [begin, end) pointers like the STL
APIs is more flexible. Taking templated [begin, end) iterators instead
of pointers would be even more flexible as it would allow passing in
backtraces from e.g. an |std::list|, but at this point there is no need
for that.
This is in preparation of a major change to |HeapDumpWriter|, which will
internally use pointer ranges instead of |Backtrace| structs. Making the
deduplicator take a range removes the need to copy a range back into a
|Backtrace| struct for deduplication.
As a drive-by fix, reduce boilerplate in |StackFrameDeduplicator| tests
and add a test to ensure that trailing null pointers are stripped.
BUG=524631
Review URL: https://codereview.chromium.org/1500693002
Cr-Commit-Position: refs/heads/master@{#363528}
Diffstat (limited to 'components/policy/resources/policy_templates_sl.xtb')
0 files changed, 0 insertions, 0 deletions