diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 03:04:44 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 03:04:44 +0000 |
| commit | 222317813261b1a90ed4a99df586ed259173ae57 (patch) | |
| tree | e54bdc375c807a9dc10684db0d43319dec822612 /components/policy | |
| parent | 586af972c34677831c6f7adefc179a633d084914 (diff) | |
| download | chromium_src-222317813261b1a90ed4a99df586ed259173ae57.zip chromium_src-222317813261b1a90ed4a99df586ed259173ae57.tar.gz chromium_src-222317813261b1a90ed4a99df586ed259173ae57.tar.bz2 | |
Extirpate CreateBooleanValue.
BUG=160586
Review URL: https://codereview.chromium.org/399433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/policy')
4 files changed, 6 insertions, 8 deletions
diff --git a/components/policy/core/browser/autofill_policy_handler.cc b/components/policy/core/browser/autofill_policy_handler.cc index 683c78a..f70fe40 100644 --- a/components/policy/core/browser/autofill_policy_handler.cc +++ b/components/policy/core/browser/autofill_policy_handler.cc @@ -23,10 +23,8 @@ void AutofillPolicyHandler::ApplyPolicySettings(const PolicyMap& policies, PrefValueMap* prefs) { const base::Value* value = policies.GetValue(policy_name()); bool auto_fill_enabled; - if (value && value->GetAsBoolean(&auto_fill_enabled) && !auto_fill_enabled) { - prefs->SetValue(autofill::prefs::kAutofillEnabled, - base::Value::CreateBooleanValue(false)); - } + if (value && value->GetAsBoolean(&auto_fill_enabled) && !auto_fill_enabled) + prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false); } } // namespace policy diff --git a/components/policy/core/common/mac_util.cc b/components/policy/core/common/mac_util.cc index df1054e..eebb931 100644 --- a/components/policy/core/common/mac_util.cc +++ b/components/policy/core/common/mac_util.cc @@ -48,8 +48,8 @@ scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) { return scoped_ptr<base::Value>(base::Value::CreateNullValue()); if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) { - return scoped_ptr<base::Value>( - base::Value::CreateBooleanValue(CFBooleanGetValue(boolean))); + return scoped_ptr<base::Value>(new base::FundamentalValue( + static_cast<bool>(CFBooleanGetValue(boolean)))); } if (CFNumberRef number = CFCast<CFNumberRef>(property)) { diff --git a/components/policy/core/common/registry_dict_win.cc b/components/policy/core/common/registry_dict_win.cc index 143956d..dc78ebc 100644 --- a/components/policy/core/common/registry_dict_win.cc +++ b/components/policy/core/common/registry_dict_win.cc @@ -71,7 +71,7 @@ scoped_ptr<base::Value> ConvertValue(const base::Value& value, (value.GetAsString(&string_value) && base::StringToInt(string_value, &int_value))) { return scoped_ptr<base::Value>( - base::Value::CreateBooleanValue(int_value != 0)); + new base::FundamentalValue(int_value != 0)); } break; } diff --git a/components/policy/tools/generate_policy_source.py b/components/policy/tools/generate_policy_source.py index ded63c2..c3957c7 100755 --- a/components/policy/tools/generate_policy_source.py +++ b/components/policy/tools/generate_policy_source.py @@ -856,7 +856,7 @@ CPP_FOOT = '''} def _CreateValue(type, arg): if type == 'TYPE_BOOLEAN': - return 'base::Value::CreateBooleanValue(%s)' % arg + return 'new base::FundamentalValue(%s)' % arg elif type == 'TYPE_INTEGER': return 'DecodeIntegerValue(%s)' % arg elif type == 'TYPE_STRING': |