Replicating WebFrame::uniqueName across renderers.

When a frame is navigated, it might be moved to another renderer
process.  During such move, the other renderer process will create a
local frame object (and the old renderer process will have a remote
frame object).  It is important that the new local frame object has the
same unique name as the frame used to have in the old renderer object.
If the unique name is not correctly replicated to the other renderer
process, then Layout Tests (i.e.
http/tests/security/cross-origin-appcache-allowed.html) fail when run in
site isolation mode (i.e. with --additional-drt-flag=--site-per-process
flag;  note that site isolation mode won't work without extra CLs like
crrev.com/1589643003).

This CL adds a |unique_name| field to the content::FrameReplicationState
struct and plumbs this value from the renderer, through the browser
and back to the renderers.

BUG=576969
TBR=gene@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1635873003

Cr-Commit-Position: refs/heads/master@{#376772}

1 files changed, 6 insertions, 4 deletions

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index 5b4b452..823c957 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -616,8 +616,9 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,
       blink::WebLocalFrame* parent,
       blink::WebTreeScopeType scope,
       const blink::WebString& name,
-      blink::WebSandboxFlags sandboxFlags,
-      const blink::WebFrameOwnerProperties& frameOwnerProperties) override;
+      const blink::WebString& unique_name,
+      blink::WebSandboxFlags sandbox_flags,
+      const blink::WebFrameOwnerProperties& frame_owner_properties) override;
   void frameDetached(blink::WebFrame* frame, DetachType type) override;
 
   void CallOnReady();
@@ -761,8 +762,9 @@ blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(
     blink::WebLocalFrame* parent,
     blink::WebTreeScopeType scope,
     const blink::WebString& name,
-    blink::WebSandboxFlags sandboxFlags,
-    const blink::WebFrameOwnerProperties& frameOwnerProperties) {
+    const blink::WebString& unique_name,
+    blink::WebSandboxFlags sandbox_flags,
+    const blink::WebFrameOwnerProperties& frame_owner_properties) {
   blink::WebFrame* frame = blink::WebLocalFrame::create(scope, this);
   parent->appendChild(frame);
   return frame;