diff options
author | vmpstr <vmpstr@chromium.org> | 2016-02-25 15:55:40 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-25 23:56:46 +0000 |
commit | b6449d51ce2b1140e763a79b2ca453f3ccedeeac (patch) | |
tree | 618db0f8e5315b69b0880278398a4f38513fbb13 /components/safe_browsing_db | |
parent | 1f354ca0573b81547e0921f2a015915a7ccc3dbd (diff) | |
download | chromium_src-b6449d51ce2b1140e763a79b2ca453f3ccedeeac.zip chromium_src-b6449d51ce2b1140e763a79b2ca453f3ccedeeac.tar.gz chromium_src-b6449d51ce2b1140e763a79b2ca453f3ccedeeac.tar.bz2 |
components: Add out-of-line copy ctors for complex classes.
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=jochen@chromium.org, dcheng@chromium.org, thakis@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1728033002
Cr-Commit-Position: refs/heads/master@{#377717}
Diffstat (limited to 'components/safe_browsing_db')
-rw-r--r-- | components/safe_browsing_db/hit_report.cc | 2 | ||||
-rw-r--r-- | components/safe_browsing_db/hit_report.h | 1 | ||||
-rw-r--r-- | components/safe_browsing_db/util.cc | 3 | ||||
-rw-r--r-- | components/safe_browsing_db/util.h | 1 |
4 files changed, 7 insertions, 0 deletions
diff --git a/components/safe_browsing_db/hit_report.cc b/components/safe_browsing_db/hit_report.cc index e8ae64e..cd14044 100644 --- a/components/safe_browsing_db/hit_report.cc +++ b/components/safe_browsing_db/hit_report.cc @@ -8,6 +8,8 @@ namespace safe_browsing { HitReport::HitReport() {} +HitReport::HitReport(const HitReport& other) = default; + HitReport::~HitReport() {} } // namespace safe_browsing diff --git a/components/safe_browsing_db/hit_report.h b/components/safe_browsing_db/hit_report.h index 618db53..881a01f 100644 --- a/components/safe_browsing_db/hit_report.h +++ b/components/safe_browsing_db/hit_report.h @@ -27,6 +27,7 @@ enum class ThreatSource { // sent as a POST instead of a GET. struct HitReport { HitReport(); + HitReport(const HitReport& other); ~HitReport(); GURL malicious_url; diff --git a/components/safe_browsing_db/util.cc b/components/safe_browsing_db/util.cc index 82ae16b..18dd9f8 100644 --- a/components/safe_browsing_db/util.cc +++ b/components/safe_browsing_db/util.cc @@ -37,6 +37,9 @@ SBCachedFullHashResult::SBCachedFullHashResult( const base::Time& in_expire_after) : expire_after(in_expire_after) {} +SBCachedFullHashResult::SBCachedFullHashResult( + const SBCachedFullHashResult& other) = default; + SBCachedFullHashResult::~SBCachedFullHashResult() {} // Listnames that browser can process. diff --git a/components/safe_browsing_db/util.h b/components/safe_browsing_db/util.h index 50134a0..8f82c60 100644 --- a/components/safe_browsing_db/util.h +++ b/components/safe_browsing_db/util.h @@ -78,6 +78,7 @@ struct SBFullHashResult { struct SBCachedFullHashResult { SBCachedFullHashResult(); explicit SBCachedFullHashResult(const base::Time& in_expire_after); + SBCachedFullHashResult(const SBCachedFullHashResult& other); ~SBCachedFullHashResult(); base::Time expire_after; |