diff options
author | shrike <shrike@chromium.org> | 2016-02-23 17:40:36 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-24 01:41:32 +0000 |
commit | dfbf0696b713398f9e30cb5db74aae5c1b6d25fa (patch) | |
tree | 0321315910c1ed2cc121fb658043c4a7bb742d08 /components/scheduler/renderer/renderer_scheduler.h | |
parent | 396d38c7d55e1c039069017afd74488cac9060cd (diff) | |
download | chromium_src-dfbf0696b713398f9e30cb5db74aae5c1b6d25fa.zip chromium_src-dfbf0696b713398f9e30cb5db74aae5c1b6d25fa.tar.gz chromium_src-dfbf0696b713398f9e30cb5db74aae5c1b6d25fa.tar.bz2 |
Revert of Per WebViewScheduler virtual time (patchset #32 id:660001 of https://codereview.chromium.org/1646583002/ )
Reason for revert:
Regression: Mac ASan 64 Tests (1)
Suspecting this cl for cause of Mac ASan regression, from list of Sheriff-o-matic suggested cls ( https://chromium.googlesource.com/chromium/src/+log/83534ab036f32a6aa7417e64fa3bc37a0b61be9d%5E..24820c067cb649a4eee2387eda8761e776a18d63?pretty=fuller ).
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)
Build #12287 - https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/12287
[ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance
../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure
Value of: ExecuteJavaScript("run_order.join(', ')")
Actual: "c, b"
Expected: ""
Which is: 0x11200a6e0
[ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (60 ms)
[2777/2778] VirtualTimeTest.AllowVirtualTimeToAdvance (60 ms)
[ RUN ] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0
[ OK ] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0 (65 ms)
[2778/2778] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0 (65 ms)
Retrying 1 test (retry #2)
[ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance
../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure
Value of: ExecuteJavaScript("run_order.join(', ')")
Actual: "c, b"
Expected: ""
Which is: 0x10d8e66e0
[ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (62 ms)
[2779/2779] VirtualTimeTest.AllowVirtualTimeToAdvance (62 ms)
Retrying 1 test (retry #3)
[ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance
../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure
Value of: ExecuteJavaScript("run_order.join(', ')")
Actual: "c, b"
Expected: ""
Which is: 0x1159e26e0
[ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (61 ms)
Original issue's description:
> Per WebViewScheduler virtual time.
>
> This patch introduces a new per WebViewScheduler virtual time and
> wires it up into the BlinkTImers. NOTE there will be follow on
> patches where various other parts of blink will also use virtual time.
>
> For determinism some parts of blink will need to use the VirtualTime
> although new code should generally use the original non-virtual APIs.
>
> For more details see:
> https://docs.google.com/document/d/1y9KDT_ZEzT7pBeY6uzVt1dgKlwc1OB_vY4NZO1zBQmo/edit#
>
> BUG=546953
>
> Committed: https://crrev.com/0d2d2840ad6d7f149569eb42332c8c8083401234
> Cr-Commit-Position: refs/heads/master@{#377094}
TBR=esprehn@chromium.org,skyostil@chromium.org,alexclarke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=546953
Review URL: https://codereview.chromium.org/1727103002
Cr-Commit-Position: refs/heads/master@{#377181}
Diffstat (limited to 'components/scheduler/renderer/renderer_scheduler.h')
-rw-r--r-- | components/scheduler/renderer/renderer_scheduler.h | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/components/scheduler/renderer/renderer_scheduler.h b/components/scheduler/renderer/renderer_scheduler.h index 98635ba..9f9204f 100644 --- a/components/scheduler/renderer/renderer_scheduler.h +++ b/components/scheduler/renderer/renderer_scheduler.h @@ -151,6 +151,18 @@ class SCHEDULER_EXPORT RendererScheduler : public ChildScheduler { // received via OnRendererBackgrounded. Defaults to disabled. virtual void SetTimerQueueSuspensionWhenBackgroundedEnabled(bool enabled) = 0; + // Returns a double which is the number of seconds since epoch (Jan 1, 1970). + // This may represent either the real time, or a virtual time depending on + // whether or not the system is currently running a task associated with a + // virtual time domain or real time domain. + virtual double VirtualTimeSeconds() const = 0; + + // Returns a microsecond resolution platform dependant time source. + // This may represent either the real time, or a virtual time depending on + // whether or not the system is currently running a task associated with a + // virtual time domain or real time domain. + virtual double MonotonicallyIncreasingVirtualTimeSeconds() const = 0; + protected: RendererScheduler(); DISALLOW_COPY_AND_ASSIGN(RendererScheduler); |