diff options
| author | kulkarni.a <kulkarni.a@samsung.com> | 2014-09-18 02:06:21 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-18 09:06:39 +0000 |
| commit | 1293c75eefdc19ac66a3505d09d6f49aea508373 (patch) | |
| tree | 7e996a91e2097df9026ffc5d1646d25c6b52baa4 /components/storage_monitor/volume_mount_watcher_win.h | |
| parent | f60720832599bc7306d9e37e3cef5ceee4c224ce (diff) | |
| download | chromium_src-1293c75eefdc19ac66a3505d09d6f49aea508373.zip chromium_src-1293c75eefdc19ac66a3505d09d6f49aea508373.tar.gz chromium_src-1293c75eefdc19ac66a3505d09d6f49aea508373.tar.bz2 | |
Code re-factor related to WeakPtrFactory in src/component module
Changing in the initialization order of WeakPtrFactory in src/gin module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructor are executed, rendering them invalid.
BUG=303818
Review URL: https://codereview.chromium.org/573133003
Cr-Commit-Position: refs/heads/master@{#295439}
Diffstat (limited to 'components/storage_monitor/volume_mount_watcher_win.h')
| -rw-r--r-- | components/storage_monitor/volume_mount_watcher_win.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/storage_monitor/volume_mount_watcher_win.h b/components/storage_monitor/volume_mount_watcher_win.h index 5e5f05a..48f3741 100644 --- a/components/storage_monitor/volume_mount_watcher_win.h +++ b/components/storage_monitor/volume_mount_watcher_win.h @@ -112,12 +112,12 @@ class VolumeMountWatcherWin { // thread. MountPointDeviceMetadataMap device_metadata_; - base::WeakPtrFactory<VolumeMountWatcherWin> weak_factory_; - // The notifications object to use to signal newly attached volumes. Only // removable devices will be notified. StorageMonitor::Receiver* notifications_; + base::WeakPtrFactory<VolumeMountWatcherWin> weak_factory_; + DISALLOW_COPY_AND_ASSIGN(VolumeMountWatcherWin); }; |