diff options
author | bnc <bnc@chromium.org> | 2015-03-09 16:12:55 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-09 23:14:13 +0000 |
commit | cd8db1dfaf165cbca88f38ecf50a5cacc09959b1 (patch) | |
tree | 7915be516bf8ddc3d7da0156749f3536e32aa00a /components/sync_driver/fake_generic_change_processor.cc | |
parent | 982eb90bf74535cbe5e21c4eacb759c42ff424d4 (diff) | |
download | chromium_src-cd8db1dfaf165cbca88f38ecf50a5cacc09959b1.zip chromium_src-cd8db1dfaf165cbca88f38ecf50a5cacc09959b1.tar.gz chromium_src-cd8db1dfaf165cbca88f38ecf50a5cacc09959b1.tar.bz2 |
Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (patchset #2 id:20001 of https://codereview.chromium.org/986743004/)
Reason for revert:
I think this CL is responsible for tree closing compile failure https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26672/steps/compile/logs/stdio.
Original issue's description:
> [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.
>
> In this change:
> - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
> - Remove AttachmenService::GetStore. Now attachment store is owned by
> model type, there is no need to get it from AttachmentService
> - Introduce AttachmentReferrer. There is no functionality behind it yet
> and interface is not complete for it. These will come in the next change.
>
> BUG=457735
> R=maniscalco@chromium.org
> TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)
>
> Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847
> Cr-Commit-Position: refs/heads/master@{#319733}
TBR=maniscalco@chromium.org,cjhopman@chromium.org,pavely@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457735
Review URL: https://codereview.chromium.org/996473005
Cr-Commit-Position: refs/heads/master@{#319760}
Diffstat (limited to 'components/sync_driver/fake_generic_change_processor.cc')
-rw-r--r-- | components/sync_driver/fake_generic_change_processor.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/sync_driver/fake_generic_change_processor.cc b/components/sync_driver/fake_generic_change_processor.cc index 165173f..4d2675d 100644 --- a/components/sync_driver/fake_generic_change_processor.cc +++ b/components/sync_driver/fake_generic_change_processor.cc @@ -20,7 +20,7 @@ FakeGenericChangeProcessor::FakeGenericChangeProcessor( base::WeakPtr<syncer::SyncMergeResult>(), NULL, sync_factory, - nullptr), + scoped_refptr<syncer::AttachmentStore>()), sync_model_has_user_created_nodes_(true), sync_model_has_user_created_nodes_success_(true) { } |