diff options
| author | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
|---|---|---|
| committer | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
| commit | 8ac09b213e743837f51f441e51ddc5840f79cc6c (patch) | |
| tree | 2bfc36a80badf0d6b053b3f50fca62832396dd5f /components/sync_driver/generic_change_processor.cc | |
| parent | 35ea7cbc5e6e72ea9148a09f5f4643f1b9bf46d1 (diff) | |
| download | chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.zip chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.gz chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.bz2 | |
Do not update AttachmentIds after uploading attachments to sync server.
In a previous design iteration we planned to have the sync server assign
an attachments id after receiving an attachment upload. We have since
changed the design so the client is responsible for assigning the
attachment id before upload occurs.
Remove comments related to updating attachment id after upload.
Rename UpdateAttachmentIdWithServerInfo to MarkAttachmentAsOnServer.
Rename UpdateEntriesWithAttachmentId to
UpdateEntriesMarkAttachmentAsOnServer.
BUG=371522
Review URL: https://codereview.chromium.org/394293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283670 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/sync_driver/generic_change_processor.cc')
| -rw-r--r-- | components/sync_driver/generic_change_processor.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/sync_driver/generic_change_processor.cc b/components/sync_driver/generic_change_processor.cc index 7917edc..4cd943c 100644 --- a/components/sync_driver/generic_change_processor.cc +++ b/components/sync_driver/generic_change_processor.cc @@ -214,7 +214,7 @@ syncer::SyncError GenericChangeProcessor::UpdateDataTypeContext( void GenericChangeProcessor::OnAttachmentUploaded( const syncer::AttachmentId& attachment_id) { syncer::WriteTransaction trans(FROM_HERE, share_handle()); - trans.UpdateEntriesWithAttachmentId(attachment_id); + trans.UpdateEntriesMarkAttachmentAsOnServer(attachment_id); } syncer::SyncError GenericChangeProcessor::GetAllSyncDataReturnError( |