[Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync().

This is part of an effort to clean up sync's state interface.
CanStartSync more accurately represents the conceptual implication of
the conditions that the method checks.

Note that at present, this does not map perfectly to what is actually
checked when sync tries to start, but that will happen in an upcoming
change.

BUG=495192
TBR=sdefresne,pkasting

Review URL: https://codereview.chromium.org/1175243009

Cr-Commit-Position: refs/heads/master@{#334545}

1 files changed, 2 insertions, 6 deletions

diff --git a/components/sync_driver/sync_service.h b/components/sync_driver/sync_service.h
index 476f1de..1c869a3 100644
--- a/components/sync_driver/sync_service.h
+++ b/components/sync_driver/sync_service.h
@@ -67,15 +67,11 @@ class SyncService : public sync_driver::DataTypeEncryptionHandler {
   // TODO(sync): The methods below were pulled from ProfileSyncService, and
   // should be evaluated to see if they should stay.
 
-  // Returns true if sync is enabled/not suppressed and the user is logged in.
+  // Returns true if sync is allowed, requested, and the user is logged in.
   // (being logged in does not mean that tokens are available - tokens may
   // be missing because they have not loaded yet, or because they were deleted
   // due to http://crbug.com/121755).
-  // Virtual to enable mocking in tests.
-  // TODO(tim): Remove this? Nothing in ProfileSyncService uses it, and outside
-  // callers use a seemingly arbitrary / redundant / bug prone combination of
-  // this method, IsSyncAllowed, and others.
-  virtual bool IsSyncEnabledAndLoggedIn() = 0;
+  virtual bool CanSyncStart() const = 0;
 
   // Disables sync for user. Use ShowLoginDialog to enable.
   virtual void DisableForUser() = 0;