diff options
| author | ki.stfu <ki.stfu@gmail.com> | 2015-09-27 21:41:20 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-28 04:42:06 +0000 |
| commit | 939799a4b72e978038109fce97bf043b988428b4 (patch) | |
| tree | b5dcf22a458103cd3c7ebc35ec117665c2f2c080 /components/test_runner/test_runner.h | |
| parent | 96e79b2a53fddaac6040ca2e699c33fbdf44641c (diff) | |
| download | chromium_src-939799a4b72e978038109fce97bf043b988428b4.zip chromium_src-939799a4b72e978038109fce97bf043b988428b4.tar.gz chromium_src-939799a4b72e978038109fce97bf043b988428b4.tar.bz2 | |
Cleanup: Pass std::string as const reference from components/
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=blundell@chromium.org,jochen@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1355983002
Cr-Commit-Position: refs/heads/master@{#351023}
Diffstat (limited to 'components/test_runner/test_runner.h')
| -rw-r--r-- | components/test_runner/test_runner.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h index 4ea4ade..45ee51a 100644 --- a/components/test_runner/test_runner.h +++ b/components/test_runner/test_runner.h @@ -87,7 +87,7 @@ class TestRunner : public WebTestRunner, void ClearDevToolsLocalStorage(); void setShouldDumpAsText(bool); void setShouldDumpAsMarkup(bool); - void setCustomTextOutput(std::string text); + void setCustomTextOutput(const std::string& text); void setShouldGeneratePixelResults(bool); void setShouldDumpFrameLoadCallbacks(bool); void setShouldDumpPingLoaderCallbacks(bool); @@ -329,7 +329,7 @@ class TestRunner : public WebTestRunner, void SetXSSAuditorEnabled(bool enabled); void SetAllowUniversalAccessFromFileURLs(bool allow); void SetAllowFileAccessFromFileURLs(bool allow); - void OverridePreference(const std::string key, v8::Local<v8::Value> value); + void OverridePreference(const std::string& key, v8::Local<v8::Value> value); // Modify accept_languages in RendererPreferences. void SetAcceptLanguages(const std::string& accept_languages); |