diff options
| author | philipj <philipj@opera.com> | 2016-03-02 06:46:22 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-02 14:47:43 +0000 |
| commit | 97906458b23205d57b35626955a33b67154d2e21 (patch) | |
| tree | 3fbd20d3ac98a85b333415f361a15a210cf36840 /components/test_runner | |
| parent | a55ac737b7029b9057bc021dce6c1ef3788b212e (diff) | |
| download | chromium_src-97906458b23205d57b35626955a33b67154d2e21.zip chromium_src-97906458b23205d57b35626955a33b67154d2e21.tar.gz chromium_src-97906458b23205d57b35626955a33b67154d2e21.tar.bz2 | |
Make DeviceOrientationEvent.prototype.absolute non-nullable
This is to match the spec and Gecko:
http://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientation
https://hg.mozilla.org/mozilla-central/file/85e218929a7a/dom/webidl/DeviceOrientationEvent.webidl
BUG=460722
Review URL: https://codereview.chromium.org/1737443002
Cr-Commit-Position: refs/heads/master@{#378747}
Diffstat (limited to 'components/test_runner')
| -rw-r--r-- | components/test_runner/test_runner.cc | 7 | ||||
| -rw-r--r-- | components/test_runner/test_runner.h | 2 |
2 files changed, 3 insertions, 6 deletions
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc index d78c862..836924e 100644 --- a/components/test_runner/test_runner.cc +++ b/components/test_runner/test_runner.cc @@ -988,7 +988,6 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) { double beta = 0.0; bool has_gamma = false; double gamma = 0.0; - bool has_absolute = false; bool absolute = false; args->GetNext(&has_alpha); @@ -997,13 +996,12 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) { args->GetNext(&beta); args->GetNext(&has_gamma); args->GetNext(&gamma); - args->GetNext(&has_absolute); args->GetNext(&absolute); runner_->SetMockDeviceOrientation(has_alpha, alpha, has_beta, beta, has_gamma, gamma, - has_absolute, absolute); + absolute); } void TestRunnerBindings::SetMockScreenOrientation( @@ -2488,7 +2486,7 @@ void TestRunner::SetMockDeviceMotion( void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha, bool has_beta, double beta, bool has_gamma, double gamma, - bool has_absolute, bool absolute) { + bool absolute) { WebDeviceOrientationData orientation; // alpha @@ -2504,7 +2502,6 @@ void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha, orientation.gamma = gamma; // absolute - orientation.hasAbsolute = has_absolute; orientation.absolute = absolute; delegate_->SetDeviceOrientationData(orientation); diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h index 777d5bb..1c359e7 100644 --- a/components/test_runner/test_runner.h +++ b/components/test_runner/test_runner.h @@ -304,7 +304,7 @@ class TestRunner : public WebTestRunner, void SetMockDeviceOrientation(bool has_alpha, double alpha, bool has_beta, double beta, bool has_gamma, double gamma, - bool has_absolute, bool absolute); + bool absolute); void SetMockScreenOrientation(const std::string& orientation); void DisableMockScreenOrientation(); |