diff options
| author | wangxianzhu@chromium.org <wangxianzhu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 19:48:19 +0000 |
|---|---|---|
| committer | wangxianzhu@chromium.org <wangxianzhu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 19:48:19 +0000 |
| commit | 6174a36970df96acaa6a4bc00bb46727ddb6e7a7 (patch) | |
| tree | fd540c556137ed279c13ddabe8ac3f0ed0fb3697 /components/tracing/tracing_messages.h | |
| parent | 6a3ad06b4dc301ff395a13605e7ab7439d9680d4 (diff) | |
| download | chromium_src-6174a36970df96acaa6a4bc00bb46727ddb6e7a7.zip chromium_src-6174a36970df96acaa6a4bc00bb46727ddb6e7a7.tar.gz chromium_src-6174a36970df96acaa6a4bc00bb46727ddb6e7a7.tar.bz2 | |
Reapply "Remove TraceController"
This reverts https://codereview.chromium.org/101543004/ which was created when
suspected the reason of failure of telemetry tests, but turned out not the real
reason. Reapply.
Reapply the following change:
> Revert "Revert 237280 "Remove TraceController""
>
> This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4.
>
> Fixed double-close issue when ending recording.
>
> > Revert 237280 "Remove TraceController"
> >
> > Seems to have broken trace-based telemetry benchmarks on android.
> >
> > BUG=323749
> >
> > > Remove TraceController
> > >
> > > TraceController is obsoleted by TracingController.
> > > Changed all remaining clients to use TracingController.
> > >
> > > BUG=none
> > >
> > > Review URL: https://codereview.chromium.org/67683003
> >
> > TBR=wangxianzhu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/89753004
> >
> > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
>
> TBR=wangxianzhu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238234
TBR=
Review URL: https://codereview.chromium.org/102003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238442 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/tracing/tracing_messages.h')
| -rw-r--r-- | components/tracing/tracing_messages.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/components/tracing/tracing_messages.h b/components/tracing/tracing_messages.h index 25b45bd..1107baf 100644 --- a/components/tracing/tracing_messages.h +++ b/components/tracing/tracing_messages.h @@ -30,7 +30,7 @@ IPC_MESSAGE_CONTROL3(TracingMsg_EnableMonitoring, base::TimeTicks /* browser_time */, int /* base::debug::TraceLog::Options */) -// Sent to all child processes to stop monitoring.. +// Sent to all child processes to stop monitoring. IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring) // Sent to all child processes to capture the current monitorint snapshot. @@ -47,6 +47,9 @@ IPC_MESSAGE_CONTROL2(TracingMsg_SetWatchEvent, // Sent to all child processes to clear watch event. IPC_MESSAGE_CONTROL0(TracingMsg_CancelWatchEvent) +// Sent everytime when a watch event is matched. +IPC_MESSAGE_CONTROL0(TracingHostMsg_WatchEventMatched); + // Notify the browser that this child process supports tracing. IPC_MESSAGE_CONTROL0(TracingHostMsg_ChildSupportsTracing) @@ -57,10 +60,6 @@ IPC_MESSAGE_CONTROL1(TracingHostMsg_EndTracingAck, // Reply from child processes acking TracingMsg_CaptureMonitoringSnapshot. IPC_MESSAGE_CONTROL0(TracingHostMsg_CaptureMonitoringSnapshotAck) -// Sent if the trace buffer becomes full. -IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceNotification, - int /* base::debug::TraceLog::Notification */) - // Child processes send back trace data in JSON chunks. IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceDataCollected, std::string /*json trace data*/) |