diff options
| author | ki.stfu <ki.stfu@gmail.com> | 2015-09-27 21:41:20 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-28 04:42:06 +0000 |
| commit | 939799a4b72e978038109fce97bf043b988428b4 (patch) | |
| tree | b5dcf22a458103cd3c7ebc35ec117665c2f2c080 /components/tracing | |
| parent | 96e79b2a53fddaac6040ca2e699c33fbdf44641c (diff) | |
| download | chromium_src-939799a4b72e978038109fce97bf043b988428b4.zip chromium_src-939799a4b72e978038109fce97bf043b988428b4.tar.gz chromium_src-939799a4b72e978038109fce97bf043b988428b4.tar.bz2 | |
Cleanup: Pass std::string as const reference from components/
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=blundell@chromium.org,jochen@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1355983002
Cr-Commit-Position: refs/heads/master@{#351023}
Diffstat (limited to 'components/tracing')
| -rw-r--r-- | components/tracing/trace_config_file.cc | 2 | ||||
| -rw-r--r-- | components/tracing/trace_config_file.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/components/tracing/trace_config_file.cc b/components/tracing/trace_config_file.cc index 796eb1b..769d527 100644 --- a/components/tracing/trace_config_file.cc +++ b/components/tracing/trace_config_file.cc @@ -87,7 +87,7 @@ TraceConfigFile::TraceConfigFile() TraceConfigFile::~TraceConfigFile() { } -bool TraceConfigFile::ParseTraceConfigFileContent(std::string content) { +bool TraceConfigFile::ParseTraceConfigFileContent(const std::string& content) { scoped_ptr<base::Value> value(base::JSONReader::Read(content)); if (!value || !value->IsType(base::Value::TYPE_DICTIONARY)) return false; diff --git a/components/tracing/trace_config_file.h b/components/tracing/trace_config_file.h index 6fafda97..863fee4 100644 --- a/components/tracing/trace_config_file.h +++ b/components/tracing/trace_config_file.h @@ -81,7 +81,7 @@ class TRACING_EXPORT TraceConfigFile { TraceConfigFile(); ~TraceConfigFile(); - bool ParseTraceConfigFileContent(std::string content); + bool ParseTraceConfigFileContent(const std::string& content); bool is_enabled_; base::trace_event::TraceConfig trace_config_; |