summaryrefslogtreecommitdiffstats
path: root/components/translate.gypi
diff options
context:
space:
mode:
authordroger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-05 13:11:54 +0000
committerdroger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-05 13:11:54 +0000
commit0bf9082d2bece5f81191a1e9cdb66af794157f21 (patch)
tree03bff4048c8d313aa45f4860fb8a898f8d6eae1a /components/translate.gypi
parent5275fc2c7edf6e680da8d296e0374adb9c5408b8 (diff)
downloadchromium_src-0bf9082d2bece5f81191a1e9cdb66af794157f21.zip
chromium_src-0bf9082d2bece5f81191a1e9cdb66af794157f21.tar.gz
chromium_src-0bf9082d2bece5f81191a1e9cdb66af794157f21.tar.bz2
Move TranslateLanguageList to the Translate component
A lot of static methods from TranslateManager are moved to TranslateDownloadManager, as they are related to the management of the TranslateLanguageList. The observer interface for translate events has been moved from TranslateManager to TranslateLanguageList. It also has been changed into a callback list rather than an observer list, since observers with a single method are generally discouraged. The SetSupportedLanguages() method in TranslateLanguageList has been moved from the anonymous namespace as it needs to invoke the callbacks for translate events. Finally, this CL fixes a bug where the TranslateList was not listening to ResourceRequestNotifications. BUG=335077, 335085, 339508 R=blundell@chromium.org, jochen@chromium.org, joi@chromium.org, mad@chromium.org TBR=jochen, joi, sky Review URL: https://codereview.chromium.org/143003020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248975 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/translate.gypi')
-rw-r--r--components/translate.gypi8
1 files changed, 8 insertions, 0 deletions
diff --git a/components/translate.gypi b/components/translate.gypi
index a61b836..d38d2b3 100644
--- a/components/translate.gypi
+++ b/components/translate.gypi
@@ -11,8 +11,10 @@
'language_usage_metrics',
'translate_core_common',
'../base/base.gyp:base',
+ '../google_apis/google_apis.gyp:google_apis',
'../net/net.gyp:net',
'../url/url.gyp:url_lib',
+ '../ui/ui.gyp:ui',
],
'include_dirs': [
'..',
@@ -29,8 +31,12 @@
'translate/core/browser/translate_error_details.h',
'translate/core/browser/translate_event_details.cc',
'translate/core/browser/translate_event_details.h',
+ 'translate/core/browser/translate_language_list.cc',
+ 'translate/core/browser/translate_language_list.h',
'translate/core/browser/translate_url_fetcher.cc',
'translate/core/browser/translate_url_fetcher.h',
+ 'translate/core/browser/translate_url_util.cc',
+ 'translate/core/browser/translate_url_util.h',
],
},
{
@@ -49,6 +55,8 @@
'translate/core/common/translate_errors.h',
'translate/core/common/translate_metrics.cc',
'translate/core/common/translate_metrics.h',
+ 'translate/core/common/translate_pref_names.cc',
+ 'translate/core/common/translate_pref_names.h',
'translate/core/common/translate_switches.cc',
'translate/core/common/translate_switches.h',
'translate/core/common/translate_util.cc',