diff options
author | vadimt <vadimt@chromium.org> | 2014-10-29 15:10:41 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-29 22:11:04 +0000 |
commit | 09e7ebe02c71d923e4655a0ad5e151b97344f091 (patch) | |
tree | 116297765f286720af9aff161fafeca63486a1a6 /components/translate | |
parent | 2ab60d98289be5804e38ea8fdebcf78740fca095 (diff) | |
download | chromium_src-09e7ebe02c71d923e4655a0ad5e151b97344f091.zip chromium_src-09e7ebe02c71d923e4655a0ad5e151b97344f091.tar.gz chromium_src-09e7ebe02c71d923e4655a0ad5e151b97344f091.tar.bz2 |
Switching profiler instrumentations from ScopedProfile to ScopedTracker. This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process.
This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel.
BUG=401560
Review URL: https://codereview.chromium.org/686963002
Cr-Commit-Position: refs/heads/master@{#301950}
Diffstat (limited to 'components/translate')
3 files changed, 17 insertions, 17 deletions
diff --git a/components/translate/core/browser/translate_language_list.cc b/components/translate/core/browser/translate_language_list.cc index 5db1a1c..0edd96c 100644 --- a/components/translate/core/browser/translate_language_list.cc +++ b/components/translate/core/browser/translate_language_list.cc @@ -10,7 +10,7 @@ #include "base/json/json_reader.h" #include "base/lazy_instance.h" #include "base/logging.h" -#include "base/profiler/scoped_profile.h" +#include "base/profiler/scoped_tracker.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/values.h" @@ -229,8 +229,8 @@ void TranslateLanguageList::OnLanguageListFetchComplete( int id, bool success, const std::string& data) { - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateLanguageList::OnLanguageListFetchComplete")); @@ -256,8 +256,8 @@ void TranslateLanguageList::OnLanguageListFetchComplete( } void TranslateLanguageList::NotifyEvent(int line, const std::string& message) { - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateLanguageList::NotifyEvent")); @@ -267,8 +267,8 @@ void TranslateLanguageList::NotifyEvent(int line, const std::string& message) { void TranslateLanguageList::SetSupportedLanguages( const std::string& language_list) { - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile1( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile1( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateLanguageList::SetSupportedLanguages 1")); @@ -295,16 +295,16 @@ void TranslateLanguageList::SetSupportedLanguages( kLanguageListCallbackNameLength, language_list.size() - kLanguageListCallbackNameLength - 1); - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile2( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile2( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateLanguageList::SetSupportedLanguages 2")); scoped_ptr<base::Value> json_value( base::JSONReader::Read(languages_json, base::JSON_ALLOW_TRAILING_COMMAS)); - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile3( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile3( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateLanguageList::SetSupportedLanguages 3")); diff --git a/components/translate/core/browser/translate_script.cc b/components/translate/core/browser/translate_script.cc index ff4288c..caa60ee 100644 --- a/components/translate/core/browser/translate_script.cc +++ b/components/translate/core/browser/translate_script.cc @@ -8,7 +8,7 @@ #include "base/command_line.h" #include "base/logging.h" #include "base/message_loop/message_loop.h" -#include "base/profiler/scoped_profile.h" +#include "base/profiler/scoped_tracker.h" #include "base/strings/string_piece.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" @@ -118,8 +118,8 @@ void TranslateScript::Request(const RequestCallback& callback) { void TranslateScript::OnScriptFetchComplete( int id, bool success, const std::string& data) { - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateScript::OnScriptFetchComplete")); diff --git a/components/translate/core/browser/translate_url_fetcher.cc b/components/translate/core/browser/translate_url_fetcher.cc index 3505ddb..4c551e0 100644 --- a/components/translate/core/browser/translate_url_fetcher.cc +++ b/components/translate/core/browser/translate_url_fetcher.cc @@ -4,7 +4,7 @@ #include "components/translate/core/browser/translate_url_fetcher.h" -#include "base/profiler/scoped_profile.h" +#include "base/profiler/scoped_tracker.h" #include "components/translate/core/browser/translate_download_manager.h" #include "net/base/load_flags.h" #include "net/http/http_status_code.h" @@ -68,8 +68,8 @@ bool TranslateURLFetcher::Request( } void TranslateURLFetcher::OnURLFetchComplete(const net::URLFetcher* source) { - // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed. - tracked_objects::ScopedProfile tracking_profile( + // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. + tracked_objects::ScopedTracker tracking_profile( FROM_HERE_WITH_EXPLICIT_FUNCTION( "422577 TranslateURLFetcher::OnURLFetchComplete")); |