diff options
| author | kkhorimoto <kkhorimoto@chromium.org> | 2015-01-06 16:28:40 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-07 00:30:06 +0000 |
| commit | 64c523540529f62a66f6a52e888317bf7fc262c1 (patch) | |
| tree | a54c507a3dda57cbe4ff3749678c3d259ffc2114 /components/translate | |
| parent | 8e236456ec39379944823698e3b9d083fbf3979e (diff) | |
| download | chromium_src-64c523540529f62a66f6a52e888317bf7fc262c1.zip chromium_src-64c523540529f62a66f6a52e888317bf7fc262c1.tar.gz chromium_src-64c523540529f62a66f6a52e888317bf7fc262c1.tar.bz2 | |
Added |load_completion_status| to WebStateObserver's |PageLoaded|.
This CL also introduces the web::PageLoadCompletionStatus enum.
This was done to support future WebStateObserver subclasses that
require notifications of failed page loads.
BUG=none
Review URL: https://codereview.chromium.org/835203002
Cr-Commit-Position: refs/heads/master@{#310188}
Diffstat (limited to 'components/translate')
| -rw-r--r-- | components/translate/ios/browser/language_detection_controller.h | 3 | ||||
| -rw-r--r-- | components/translate/ios/browser/language_detection_controller.mm | 6 |
2 files changed, 6 insertions, 3 deletions
diff --git a/components/translate/ios/browser/language_detection_controller.h b/components/translate/ios/browser/language_detection_controller.h index 28f3efa..5c1b075 100644 --- a/components/translate/ios/browser/language_detection_controller.h +++ b/components/translate/ios/browser/language_detection_controller.h @@ -76,7 +76,8 @@ class LanguageDetectionController : public web::WebStateObserver { const base::string16& text); // web::WebStateObserver implementation: - void PageLoaded() override; + void PageLoaded( + web::PageLoadCompletionStatus load_completion_status) override; void URLHashChanged() override; void HistoryStateChanged() override; void WebStateDestroyed() override; diff --git a/components/translate/ios/browser/language_detection_controller.mm b/components/translate/ios/browser/language_detection_controller.mm index b8ea2be..24d7a80 100644 --- a/components/translate/ios/browser/language_detection_controller.mm +++ b/components/translate/ios/browser/language_detection_controller.mm @@ -127,8 +127,10 @@ void LanguageDetectionController::OnTextRetrieved( // web::WebStateObserver implementation: -void LanguageDetectionController::PageLoaded() { - StartLanguageDetection(); +void LanguageDetectionController::PageLoaded( + web::PageLoadCompletionStatus load_completion_status) { + if (load_completion_status == web::PageLoadCompletionStatus::SUCCESS) + StartLanguageDetection(); } void LanguageDetectionController::URLHashChanged() { |