diff options
author | dcheng <dcheng@chromium.org> | 2014-12-30 13:40:58 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-30 21:42:42 +0000 |
commit | 6a89b90150b02f7a2c7f56faf9913eaf40f6de17 (patch) | |
tree | ef9b6971622f769b94f885565d42b46006d4e5cb /components/translate | |
parent | 2ce4615599f4c286b9de5da1eaa8c97da421d295 (diff) | |
download | chromium_src-6a89b90150b02f7a2c7f56faf9913eaf40f6de17.zip chromium_src-6a89b90150b02f7a2c7f56faf9913eaf40f6de17.tar.gz chromium_src-6a89b90150b02f7a2c7f56faf9913eaf40f6de17.tar.bz2 |
Standardize usage of virtual/override/final specifiers in components/.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.
BUG=417463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/824513003
Cr-Commit-Position: refs/heads/master@{#309781}
Diffstat (limited to 'components/translate')
-rw-r--r-- | components/translate/content/renderer/renderer_cld_data_provider.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/translate/content/renderer/renderer_cld_data_provider.h b/components/translate/content/renderer/renderer_cld_data_provider.h index b5ae4b7..b4ba69b 100644 --- a/components/translate/content/renderer/renderer_cld_data_provider.h +++ b/components/translate/content/renderer/renderer_cld_data_provider.h @@ -40,7 +40,7 @@ class RendererCldDataProvider : public IPC::Listener { // This method is defined as virtual in order to force the implementation to // define the specific IPC message(s) that it handles. // The default implementation does nothing and returns false. - virtual bool OnMessageReceived(const IPC::Message& message) override; + bool OnMessageReceived(const IPC::Message& message) override; // Invoked by the renderer process to request that CLD data be obtained and // that CLD be initialized with it. The implementation is expected to |