diff options
author | vadimt <vadimt@chromium.org> | 2014-11-04 08:53:11 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-11-04 16:53:37 +0000 |
commit | c17c4cf24972a763a82230383fd40bd29620bab3 (patch) | |
tree | cb2547e44329a9567d1ccb418f0818e1d6fbb581 /components/translate | |
parent | 16d4cbbb67e198ebad8ccb774e5ab53e6dc84303 (diff) | |
download | chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.zip chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.tar.gz chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.tar.bz2 |
Removing instrumentations for task URLFetcherCore::OnCompletedURLRequest
The jank almost disappeared, either because it was fixed, or its numbers were absorbed by other instrumentations.
At the current moment in Win, instrumentation for OAuth2AccessTokenFetcherImpl::OnURLFetchComplete shown 1.65 118ms jph, and remaining own jankiness of URLFetcherCore::OnCompletedURLRequest is 2.87.
BUG=422577
TBR=toyoshim@chromium.org, dconnelly@chromium.org, pkasting@chromium.org, zea@chromium.org, yoz@chromium.org, mmenke@chromium.org, dcheng@chromium.org, mattm@chromium.org, jhawkins@chromium.org, rogerta@chromium.org
Review URL: https://codereview.chromium.org/701463004
Cr-Commit-Position: refs/heads/master@{#302620}
Diffstat (limited to 'components/translate')
3 files changed, 0 insertions, 37 deletions
diff --git a/components/translate/core/browser/translate_language_list.cc b/components/translate/core/browser/translate_language_list.cc index 0edd96c..d791c01 100644 --- a/components/translate/core/browser/translate_language_list.cc +++ b/components/translate/core/browser/translate_language_list.cc @@ -10,7 +10,6 @@ #include "base/json/json_reader.h" #include "base/lazy_instance.h" #include "base/logging.h" -#include "base/profiler/scoped_tracker.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/values.h" @@ -229,11 +228,6 @@ void TranslateLanguageList::OnLanguageListFetchComplete( int id, bool success, const std::string& data) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateLanguageList::OnLanguageListFetchComplete")); - if (!success) { // Since it fails just now, omit to schedule resource requests if // ResourceRequestAllowedNotifier think it's ready. Otherwise, a callback @@ -256,22 +250,12 @@ void TranslateLanguageList::OnLanguageListFetchComplete( } void TranslateLanguageList::NotifyEvent(int line, const std::string& message) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateLanguageList::NotifyEvent")); - TranslateEventDetails details(__FILE__, line, message); callback_list_.Notify(details); } void TranslateLanguageList::SetSupportedLanguages( const std::string& language_list) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile1( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateLanguageList::SetSupportedLanguages 1")); - // The format is: // sl({ // "sl": {"XX": "LanguageName", ...}, @@ -295,19 +279,9 @@ void TranslateLanguageList::SetSupportedLanguages( kLanguageListCallbackNameLength, language_list.size() - kLanguageListCallbackNameLength - 1); - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile2( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateLanguageList::SetSupportedLanguages 2")); - scoped_ptr<base::Value> json_value( base::JSONReader::Read(languages_json, base::JSON_ALLOW_TRAILING_COMMAS)); - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile3( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateLanguageList::SetSupportedLanguages 3")); - if (json_value == NULL || !json_value->IsType(base::Value::TYPE_DICTIONARY)) { NOTREACHED(); return; diff --git a/components/translate/core/browser/translate_script.cc b/components/translate/core/browser/translate_script.cc index caa60ee..8c25320 100644 --- a/components/translate/core/browser/translate_script.cc +++ b/components/translate/core/browser/translate_script.cc @@ -118,11 +118,6 @@ void TranslateScript::Request(const RequestCallback& callback) { void TranslateScript::OnScriptFetchComplete( int id, bool success, const std::string& data) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateScript::OnScriptFetchComplete")); - DCHECK_EQ(kFetcherId, id); scoped_ptr<const TranslateURLFetcher> delete_ptr(fetcher_.release()); diff --git a/components/translate/core/browser/translate_url_fetcher.cc b/components/translate/core/browser/translate_url_fetcher.cc index 4c551e0..09704fd 100644 --- a/components/translate/core/browser/translate_url_fetcher.cc +++ b/components/translate/core/browser/translate_url_fetcher.cc @@ -4,7 +4,6 @@ #include "components/translate/core/browser/translate_url_fetcher.h" -#include "base/profiler/scoped_tracker.h" #include "components/translate/core/browser/translate_download_manager.h" #include "net/base/load_flags.h" #include "net/http/http_status_code.h" @@ -68,11 +67,6 @@ bool TranslateURLFetcher::Request( } void TranslateURLFetcher::OnURLFetchComplete(const net::URLFetcher* source) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 TranslateURLFetcher::OnURLFetchComplete")); - DCHECK(fetcher_.get() == source); std::string data; |