summaryrefslogtreecommitdiffstats
path: root/components/translate
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-13 16:48:41 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-13 16:50:48 +0000
commitdf80704e21578c439a2facfdaeabfe016d297353 (patch)
tree01092783052df5d2b027b80ec67011b5475e5c19 /components/translate
parent5a25b4d1b753851cab3d5100d32bbc87ca4a4e4d (diff)
downloadchromium_src-df80704e21578c439a2facfdaeabfe016d297353.zip
chromium_src-df80704e21578c439a2facfdaeabfe016d297353.tar.gz
chromium_src-df80704e21578c439a2facfdaeabfe016d297353.tar.bz2
Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."
> Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/474483002 Cr-Commit-Position: refs/heads/master@{#289320} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/translate')
-rw-r--r--components/translate/core/language_detection/language_detection_util.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/components/translate/core/language_detection/language_detection_util.cc b/components/translate/core/language_detection/language_detection_util.cc
index 29f4898..35a21b9 100644
--- a/components/translate/core/language_detection/language_detection_util.cc
+++ b/components/translate/core/language_detection/language_detection_util.cc
@@ -292,7 +292,7 @@ void CorrectLanguageCodeTypo(std::string* code) {
size_t dash_index = code->find('-');
if (dash_index != std::string::npos) {
*code = base::StringToLowerASCII(code->substr(0, dash_index)) +
- base::StringToUpperASCII(code->substr(dash_index));
+ StringToUpperASCII(code->substr(dash_index));
} else {
*code = base::StringToLowerASCII(*code);
}