diff options
author | tommi <tommi@chromium.org> | 2015-08-23 01:38:46 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-23 08:39:32 +0000 |
commit | d5661a88da3abe82351550a7b7aa737bd4b41cfb (patch) | |
tree | e435b8397e49f1436ed3d72c6a777e283461c0d9 /components/visitedlink | |
parent | 38b337c52472b3fbe0373236f505437709093c8f (diff) | |
download | chromium_src-d5661a88da3abe82351550a7b7aa737bd4b41cfb.zip chromium_src-d5661a88da3abe82351550a7b7aa737bd4b41cfb.tar.gz chromium_src-d5661a88da3abe82351550a7b7aa737bd4b41cfb.tar.bz2 |
Revert of Add more components tests to GN build. (patchset #3 id:40001 of https://codereview.chromium.org/1303013005/ )
Reason for revert:
Breaks compile on the Win GN bot:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN%20%28dbg%29&number=8108
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8108/steps/compile/logs/stdio
Original issue's description:
> Add more components tests to GN build.
>
> visitedlink, query_parser, web_cache, autofill
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel
> TBR=-dpranke@chromium.org
>
> Committed: https://crrev.com/0eb6b59c463a0aa9dd01956b5542b8cf158e835a
> Cr-Commit-Position: refs/heads/master@{#344993}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1308763004
Cr-Commit-Position: refs/heads/master@{#344999}
Diffstat (limited to 'components/visitedlink')
-rw-r--r-- | components/visitedlink/browser/BUILD.gn | 3 | ||||
-rw-r--r-- | components/visitedlink/common/BUILD.gn | 3 | ||||
-rw-r--r-- | components/visitedlink/renderer/BUILD.gn | 27 | ||||
-rw-r--r-- | components/visitedlink/test/BUILD.gn | 16 |
4 files changed, 18 insertions, 31 deletions
diff --git a/components/visitedlink/browser/BUILD.gn b/components/visitedlink/browser/BUILD.gn index fa2e70ce..4fce197 100644 --- a/components/visitedlink/browser/BUILD.gn +++ b/components/visitedlink/browser/BUILD.gn @@ -2,7 +2,8 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -source_set("browser") { +static_library("browser") { + output_name = "visitedlink_browser" sources = [ "visitedlink_delegate.h", "visitedlink_event_listener.cc", diff --git a/components/visitedlink/common/BUILD.gn b/components/visitedlink/common/BUILD.gn index 712e8d0..2c472d0 100644 --- a/components/visitedlink/common/BUILD.gn +++ b/components/visitedlink/common/BUILD.gn @@ -2,7 +2,8 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -source_set("common") { +static_library("common") { + output_name = "visitedlink_common" sources = [ "visitedlink_common.cc", "visitedlink_common.h", diff --git a/components/visitedlink/renderer/BUILD.gn b/components/visitedlink/renderer/BUILD.gn index 2b95684..33618cc 100644 --- a/components/visitedlink/renderer/BUILD.gn +++ b/components/visitedlink/renderer/BUILD.gn @@ -2,18 +2,19 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -assert(!is_ios) +if (!is_ios) { + static_library("renderer") { + output_name = "visitedlink_renderer" + sources = [ + "visitedlink_slave.cc", + "visitedlink_slave.h", + ] -source_set("renderer") { - sources = [ - "visitedlink_slave.cc", - "visitedlink_slave.h", - ] - - deps = [ - "//base", - "//content/public/common", - "//content/public/renderer", - "//third_party/WebKit/public:blink", - ] + deps = [ + "//base", + "//content/public/common", + "//content/public/renderer", + "//third_party/WebKit/public:blink", + ] + } } diff --git a/components/visitedlink/test/BUILD.gn b/components/visitedlink/test/BUILD.gn deleted file mode 100644 index 3f7d742..0000000 --- a/components/visitedlink/test/BUILD.gn +++ /dev/null @@ -1,16 +0,0 @@ -# Copyright 2015 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -source_set("unit_tests") { - testonly = true - sources = [ - "visitedlink_unittest.cc", - ] - deps = [ - "//components/visitedlink/browser", - "//components/visitedlink/renderer", - "//content/test:test_support", - "//testing/gtest", - ] -} |