diff options
author | ssid <ssid@chromium.org> | 2015-11-24 09:44:54 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-11-24 17:45:50 +0000 |
commit | fccd31cc513c66944a01955638a67d23bdcc0b88 (patch) | |
tree | 81fed9e2a18458020436fa46a68756433a145c32 /components/web_cache.gypi | |
parent | 0888cffc5df1623d928740a4d3a264c16147823e (diff) | |
download | chromium_src-fccd31cc513c66944a01955638a67d23bdcc0b88.zip chromium_src-fccd31cc513c66944a01955638a67d23bdcc0b88.tar.gz chromium_src-fccd31cc513c66944a01955638a67d23bdcc0b88.tar.bz2 |
[clean-up] Remove allocator.gyp dependency from library targets
This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.
The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.
target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
chrome_android_core: not used in windows
Dependency on allocator.gyp exists already for:
All, browser (explained below)
target:browser - depends on allocator.gyp in windows
targets that depend on browser:
chrome_android_core: only android
chromevox_tests: added dependency to allocator.gyp for windows
Dependency on allocator.gyp exists already for:
All, interactive_ui_tests, browser_tests, performance_browser_tests
chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests
test_support_sync_integration's executables:
sync_integration_tests, browser_tests, sync_performance_tests
test_support_common's executables:
interactive_ui_tests, browser_tests, performance_browser_tests
test_support_unit's executables:
unit_tests
target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
chrome_android_core: not used in windows
chromevox_tests: added dependency to allocator.gyp for windows
chrome_child_dll - added dependency.
Dependency on allocator.gyp exists already for:
interactive_ui_tests, browser_tests, performance_browser_tests
sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
chrome_app_unittests
test_support_common - explained earlier.
target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
apps - browser (explained above)
browser_ui (explained above)
browser_chromeos
browser (explained above)
browser_tests
apps - browser (explained above)
target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
browser*, components_unittests
extensions_browser
extensions_unittests, browser_extensions*, apps*
media_router
browser_ui*, browser*, native_app_window - browser_ui*
javascript_dialog_extensions_client - browser_ui*
media_router_test_support
browser_tests, test_support_unit*, unit_tests
app_shell_lib
extensions_browsertests, app_shell, app_shell_unittests
extensions_test_support
extensions_unittests, extensions_browsertests, app_shell_unittests
test_support_common*
* - see previous sections for why it is fine for the target to not
depend on allocator.gyp
BUG=
Review URL: https://codereview.chromium.org/1462853002
Cr-Commit-Position: refs/heads/master@{#361381}
Diffstat (limited to 'components/web_cache.gypi')
-rw-r--r-- | components/web_cache.gypi | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/components/web_cache.gypi b/components/web_cache.gypi index a42e344..53b0714 100644 --- a/components/web_cache.gypi +++ b/components/web_cache.gypi @@ -31,13 +31,6 @@ ], # Disable c4267 warnings until we fix size_t to int truncations. 'msvs_disabled_warnings': [ 4267, ], - 'conditions': [ - ['OS=="win" and win_use_allocator_shim==1', { - 'dependencies': [ - '../base/allocator/allocator.gyp:allocator', - ], - }], - ], }, { 'target_name': 'web_cache_renderer', |