diff options
| author | brettw <brettw@chromium.org> | 2015-07-16 10:49:29 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-16 17:50:12 +0000 |
| commit | a7ff1b291cd328e9584779a4bb9101fa9a3c01ad (patch) | |
| tree | d010374be1ca156ea26405ae7b0aa85e48bb4bba /components/wifi | |
| parent | 7befa9cf85342a0409502ed2c05d7610afec7844 (diff) | |
| download | chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.zip chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.tar.gz chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.tar.bz2 | |
Remove some legacy versions of StartsWith and EndsWith.
This just replaces
true -> base::CompareCase::SENSITIVE
false -> base::CompareCase::INSENSITIVE_ASCII
I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at.
extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable.
BUG=506255
TBR=jam
Reland of http://crrev.com/1239493005
Review URL: https://codereview.chromium.org/1233043003
Cr-Commit-Position: refs/heads/master@{#339071}
Diffstat (limited to 'components/wifi')
| -rw-r--r-- | components/wifi/wifi_service_win.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/components/wifi/wifi_service_win.cc b/components/wifi/wifi_service_win.cc index f20c26e..2716136 100644 --- a/components/wifi/wifi_service_win.cc +++ b/components/wifi/wifi_service_win.cc @@ -1154,7 +1154,8 @@ DWORD WiFiServiceImpl::FindAdapterIndexMapByGUID( if (error == ERROR_SUCCESS) { for (int adapter = 0; adapter < interface_info->NumAdapters; ++adapter) { if (base::EndsWith( - interface_info->Adapter[adapter].Name, guid_string, false)) { + interface_info->Adapter[adapter].Name, guid_string, + base::CompareCase::INSENSITIVE_ASCII)) { *adapter_index_map = interface_info->Adapter[adapter]; break; } |