summaryrefslogtreecommitdiffstats
path: root/components
diff options
context:
space:
mode:
authoraurimas <aurimas@chromium.org>2015-05-15 20:05:04 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-16 03:05:49 +0000
commit34e43ad7fc1cc245cd281dd56a9962f169a62307 (patch)
treee1f3d93efa5e95e8274eaaf9efe24c842b1d9c2e /components
parentc8f25a2646023a1be95dde6459c71fe702a1f201 (diff)
downloadchromium_src-34e43ad7fc1cc245cd281dd56a9962f169a62307.zip
chromium_src-34e43ad7fc1cc245cd281dd56a9962f169a62307.tar.gz
chromium_src-34e43ad7fc1cc245cd281dd56a9962f169a62307.tar.bz2
Revert of Disable user gesture checking for all autofill browser tests. (patchset #2 id:20001 of https://codereview.chromium.org/1125173006/)
Reason for revert: This CL broke Linux GN Clobber bot. Original issue's description: > Disable user gesture checking for all autofill browser tests. > > When drmemory_full runs, the browser tests are slowed down enough to > timeout the user gesture indicator, which prevents autofill from > processing the input and passing the browser test. The fix is to disable > user gesture checking for all autofill browser tests except > AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. > > BUG=484910 TBR=estade@chromium.org,thestig@chromium.org,rouslan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484910 Review URL: https://codereview.chromium.org/1140013004 Cr-Commit-Position: refs/heads/master@{#330272}
Diffstat (limited to 'components')
-rw-r--r--components/autofill/content/renderer/autofill_agent.cc6
-rw-r--r--components/autofill/content/renderer/autofill_agent.h4
2 files changed, 1 insertions, 9 deletions
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index bf1f54a..b994e4d 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -388,7 +388,7 @@ void AutofillAgent::textFieldDidChange(const WebFormControlElement& element) {
if (ignore_text_changes_)
return;
- if (!IsUserGesture())
+ if (!WebUserGestureIndicator::isProcessingUserGesture())
return;
// We post a task for doing the Autofill as the caret position is not set
@@ -752,10 +752,6 @@ void AutofillAgent::HidePopup() {
Send(new AutofillHostMsg_HidePopup(routing_id()));
}
-bool AutofillAgent::IsUserGesture() const {
- return WebUserGestureIndicator::isProcessingUserGesture();
-}
-
void AutofillAgent::didAssociateFormControls(const WebVector<WebNode>& nodes) {
for (size_t i = 0; i < nodes.size(); ++i) {
WebLocalFrame* frame = nodes[i].document().frame();
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index c75d5d6..39d6573 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -221,10 +221,6 @@ class AutofillAgent : public content::RenderFrameObserver,
// Hides any currently showing Autofill popup.
void HidePopup();
- // Returns true if the text field change is due to a user gesture. Can be
- // overriden in tests.
- virtual bool IsUserGesture() const;
-
// Formerly cached forms for all frames, now only caches forms for the current
// frame.
FormCache form_cache_;