diff options
| author | tzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-03 04:40:18 +0000 |
|---|---|---|
| committer | tzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-03 04:40:18 +0000 |
| commit | 690d3e34dcdd4dfcac08eeafe654bb86889db80b (patch) | |
| tree | b5891acbc07ea2eeb25a042c0118ca921481a4e6 /components | |
| parent | de46a6d6c3d5298cc0da6fa8cc1c1ca596ff79ef (diff) | |
| download | chromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.zip chromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.tar.gz chromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.tar.bz2 | |
Revert of Reduce plugin_metrics_provider_ usage in MetricsService (https://codereview.chromium.org/308433004/)
Reason for revert:
This CL seems to cause bot failure on CI:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745
Original issue's description:
> Reduce plugin_metrics_provider_ usage in MetricsService
>
> This CL eliminates MetricsService's call to
> PluginMetricsProvider::RecordPluginChanges (replaced by a new API on
> MetricsProvider). It additionally adds a
> MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer
> call that API rather than calling MetricsService directly. This change will
> enable easily moving MetricsService::LogPluginLoadingError() to
> ChromeMetricsServiceClient once the latter is the class that keeps a weak
> pointer to the plugin metrics provider.
>
> BUG=375776
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403
TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375776
Review URL: https://codereview.chromium.org/314583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274418 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
| -rw-r--r-- | components/metrics/metrics_provider.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/components/metrics/metrics_provider.h b/components/metrics/metrics_provider.h index 33bf61c..001e66a 100644 --- a/components/metrics/metrics_provider.h +++ b/components/metrics/metrics_provider.h @@ -44,9 +44,6 @@ class MetricsProvider { virtual void ProvideGeneralMetrics( ChromeUserMetricsExtension* uma_proto) {} - // TODO(asvitkine): Remove this method. http://crbug.com/379148 - virtual void RecordCurrentState() {} - private: DISALLOW_COPY_AND_ASSIGN(MetricsProvider); }; |