diff options
| author | thakis <thakis@chromium.org> | 2014-10-28 18:26:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-29 01:26:27 +0000 |
| commit | 7e7fce4e519f1f507b06ee472d367716baee5899 (patch) | |
| tree | c892b12dc6062ce12fd079cd517d81b0804e6f06 /components | |
| parent | e9c0d2eff1877f6ac6cbf9333a645432bf10438d (diff) | |
| download | chromium_src-7e7fce4e519f1f507b06ee472d367716baee5899.zip chromium_src-7e7fce4e519f1f507b06ee472d367716baee5899.tar.gz chromium_src-7e7fce4e519f1f507b06ee472d367716baee5899.tar.bz2 | |
Add a few missing overrides found by a new clang warning.
Namely, -Winconsistent-missing-override. No behavior change.
BUG=428099
TBR=blundell
Review URL: https://codereview.chromium.org/652233006
Cr-Commit-Position: refs/heads/master@{#301761}
Diffstat (limited to 'components')
3 files changed, 5 insertions, 6 deletions
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h index bec5ad5..0b943f4 100644 --- a/components/password_manager/core/browser/password_store.h +++ b/components/password_manager/core/browser/password_store.h @@ -214,11 +214,11 @@ class PasswordStore : protected PasswordStoreSync, // base::Bind can't be used with them because it fails to cast PasswordStore // to PasswordStoreSync. virtual PasswordStoreChangeList AddLoginImpl( - const autofill::PasswordForm& form) = 0; + const autofill::PasswordForm& form) override = 0; virtual PasswordStoreChangeList UpdateLoginImpl( - const autofill::PasswordForm& form) = 0; + const autofill::PasswordForm& form) override = 0; virtual PasswordStoreChangeList RemoveLoginImpl( - const autofill::PasswordForm& form) = 0; + const autofill::PasswordForm& form) override = 0; // Synchronous implementation to remove the given logins. virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl( diff --git a/components/storage_monitor/test_volume_mount_watcher_win.h b/components/storage_monitor/test_volume_mount_watcher_win.h index ed6df11..267d096 100644 --- a/components/storage_monitor/test_volume_mount_watcher_win.h +++ b/components/storage_monitor/test_volume_mount_watcher_win.h @@ -38,8 +38,6 @@ class TestVolumeMountWatcherWin : public VolumeMountWatcherWin { void FlushWorkerPoolForTesting(); - virtual void DeviceCheckComplete(const base::FilePath& device_path); - const std::vector<base::FilePath>& devices_checked() const { return devices_checked_; } @@ -49,6 +47,7 @@ class TestVolumeMountWatcherWin : public VolumeMountWatcherWin { void ReleaseDeviceCheck(); // VolumeMountWatcherWin: + virtual void DeviceCheckComplete(const base::FilePath& device_path) override; virtual GetAttachedDevicesCallbackType GetAttachedDevicesCallback() const override; virtual GetDeviceDetailsCallbackType diff --git a/components/translate/content/browser/browser_cld_data_provider.h b/components/translate/content/browser/browser_cld_data_provider.h index f46807e..da99c06 100644 --- a/components/translate/content/browser/browser_cld_data_provider.h +++ b/components/translate/content/browser/browser_cld_data_provider.h @@ -38,7 +38,7 @@ class BrowserCldDataProvider : public IPC::Listener { // OnCldDataRequest() and returns true. In all other cases, this method does // nothing. This method is defined as virtual in order to force the // implementation to define the specific IPC message(s) that it handles. - virtual bool OnMessageReceived(const IPC::Message&) = 0; + virtual bool OnMessageReceived(const IPC::Message&) override = 0; // Called when the browser process receives an appropriate message in // OnMessageReceived, above. The implementation should attempt to locate |