diff options
| author | brettw <brettw@chromium.org> | 2015-11-30 10:37:34 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-30 18:39:15 +0000 |
| commit | d92881a8127160c2b14a9136eec10196e1cd27c2 (patch) | |
| tree | 07194a1c1107ee1783893ed3ed3832173a411cf9 /components | |
| parent | 2576a02889ff97ede2fb80166888fdf85b7fb9fa (diff) | |
| download | chromium_src-d92881a8127160c2b14a9136eec10196e1cd27c2.zip chromium_src-d92881a8127160c2b14a9136eec10196e1cd27c2.tar.gz chromium_src-d92881a8127160c2b14a9136eec10196e1cd27c2.tar.bz2 | |
Comments updates from GN check additions.
Comments from https://codereview.chromium.org/1479373002/ and
https://codereview.chromium.org/1479093002/
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1487683003
Cr-Commit-Position: refs/heads/master@{#362170}
Diffstat (limited to 'components')
| -rw-r--r-- | components/proximity_auth/BUILD.gn | 5 | ||||
| -rw-r--r-- | components/proximity_auth/ble/BUILD.gn | 5 | ||||
| -rw-r--r-- | components/proximity_auth/cryptauth/BUILD.gn | 6 | ||||
| -rw-r--r-- | components/search_engines/BUILD.gn | 7 |
4 files changed, 13 insertions, 10 deletions
diff --git a/components/proximity_auth/BUILD.gn b/components/proximity_auth/BUILD.gn index 023d8dbe..c031eba 100644 --- a/components/proximity_auth/BUILD.gn +++ b/components/proximity_auth/BUILD.gn @@ -79,8 +79,9 @@ source_set("proximity_auth") { "//net", ] - # TODO bug 562683: This whitelists a circular include dependency between this - # target and the following targets which should not exist. + # TODO(https://crbug.com/562683): This whitelists a circular include + # dependency between this target and the following targets which should not + # exist. allow_circular_includes_from = [ "//components/proximity_auth/ble", "//components/proximity_auth/cryptauth", diff --git a/components/proximity_auth/ble/BUILD.gn b/components/proximity_auth/ble/BUILD.gn index 1b69f4f..1be48bd 100644 --- a/components/proximity_auth/ble/BUILD.gn +++ b/components/proximity_auth/ble/BUILD.gn @@ -26,8 +26,9 @@ source_set("ble") { "//base:prefs", "//components/proximity_auth/logging", - # TODO bug 562683: This component has a circular dependency with the root - # proximity auth target. It is whitelisted in that target for includes. + # TODO(https://crbug.com/562683): This component has a circular dependency + # with the root proximity auth target. It is whitelisted in that target for + # includes. #"//components/proximity_auth", "//device/bluetooth", "//net", diff --git a/components/proximity_auth/cryptauth/BUILD.gn b/components/proximity_auth/cryptauth/BUILD.gn index 1c59337..0578d49 100644 --- a/components/proximity_auth/cryptauth/BUILD.gn +++ b/components/proximity_auth/cryptauth/BUILD.gn @@ -35,9 +35,9 @@ source_set("cryptauth") { "sync_scheduler_impl.h", ] - # TODO bug 562685: This target is including a header from the test support - # target. To prevent "gn check" from complaining, whitelist it here, but - # this should be factored so that test headers aren't included. + # TODO(https://crbug.com/562683): This target is including a header from the + # test support target. To prevent "gn check" from complaining, whitelist it + # here, but this should be factored so that test headers aren't included. sources += [ "fake_secure_message_delegate.h" ] deps = [ diff --git a/components/search_engines/BUILD.gn b/components/search_engines/BUILD.gn index f01f123..46fb5e3 100644 --- a/components/search_engines/BUILD.gn +++ b/components/search_engines/BUILD.gn @@ -61,9 +61,10 @@ static_library("search_engines") { "//components/keyed_service/core", "//components/metrics/proto", - # This target is in an include cycle with components/omnibox/browser. - # The cycle is whitelisted in the omnibox/browser target, but should - # ideally be fixed. + # The search_engines target is in an include cycle with + # components/omnibox/browser. The cycle is whitelisted in the + # omnibox/browser target, but should ideally be fixed, then this + # dependency added: #"//components/omnibox/browser", "//components/policy:policy_component", "//components/pref_registry", |