diff options
author | Brett Wilson <brettw@chromium.org> | 2014-09-23 16:41:46 -0700 |
---|---|---|
committer | Brett Wilson <brettw@chromium.org> | 2014-09-23 23:42:24 +0000 |
commit | e5389527466d390b5653724a069008b9f1edcd5c (patch) | |
tree | b801a034992eec680db3afbfae5ed6dd6394ca7e /components | |
parent | 2261d6bc3936efca1a9387085d2ebbf367d38df4 (diff) | |
download | chromium_src-e5389527466d390b5653724a069008b9f1edcd5c.zip chromium_src-e5389527466d390b5653724a069008b9f1edcd5c.tar.gz chromium_src-e5389527466d390b5653724a069008b9f1edcd5c.tar.bz2 |
Replace forward_dependent_configs with public_deps
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
Diffstat (limited to 'components')
-rw-r--r-- | components/autofill/content/browser/BUILD.gn | 8 | ||||
-rw-r--r-- | components/autofill/core/browser/BUILD.gn | 2 | ||||
-rw-r--r-- | components/crash/browser/BUILD.gn | 2 | ||||
-rw-r--r-- | components/dom_distiller/content/BUILD.gn | 8 | ||||
-rw-r--r-- | components/dom_distiller/core/BUILD.gn | 11 | ||||
-rw-r--r-- | components/infobars/core/BUILD.gn | 7 | ||||
-rw-r--r-- | components/invalidation/BUILD.gn | 8 | ||||
-rw-r--r-- | components/metrics/BUILD.gn | 28 | ||||
-rw-r--r-- | components/omnibox/BUILD.gn | 8 | ||||
-rw-r--r-- | components/password_manager/core/browser/BUILD.gn | 10 |
10 files changed, 38 insertions, 54 deletions
diff --git a/components/autofill/content/browser/BUILD.gn b/components/autofill/content/browser/BUILD.gn index 267c72f..def5a45 100644 --- a/components/autofill/content/browser/BUILD.gn +++ b/components/autofill/content/browser/BUILD.gn @@ -36,6 +36,9 @@ static_library("browser") { "wallet/wallet_signin_helper.h", ] + public_deps = [ + "//skia", + ] deps = [ ":risk_proto", "//base", @@ -54,7 +57,6 @@ static_library("browser") { "//content/public/common", "//google_apis", "//ipc", - "//skia", "//sql", "//third_party/icu", "//third_party/libphonenumber", @@ -64,10 +66,6 @@ static_library("browser") { "//ui/gfx/geometry", "//url", ] - - forward_dependent_configs_from = [ - "//skia", - ] } proto_library("risk_proto") { diff --git a/components/autofill/core/browser/BUILD.gn b/components/autofill/core/browser/BUILD.gn index c9bd711..b31e90f 100644 --- a/components/autofill/core/browser/BUILD.gn +++ b/components/autofill/core/browser/BUILD.gn @@ -156,7 +156,7 @@ static_library("browser") { "//url", ] - direct_dependent_configs = [ ":autofill_browser_config" ] + public_configs = [ ":autofill_browser_config" ] if (autofill_enable_sync) { deps += [ "//sync" ] diff --git a/components/crash/browser/BUILD.gn b/components/crash/browser/BUILD.gn index 40686be..06a75d3 100644 --- a/components/crash/browser/BUILD.gn +++ b/components/crash/browser/BUILD.gn @@ -33,6 +33,6 @@ source_set("browser") { if (is_posix && !is_ios && (!is_android || !is_android_webview_build)) { configs += [ "//breakpad:client_config" ] - direct_dependent_configs = [ "//breakpad:client_config" ] + public_configs = [ "//breakpad:client_config" ] } } diff --git a/components/dom_distiller/content/BUILD.gn b/components/dom_distiller/content/BUILD.gn index 998665a..5e471276 100644 --- a/components/dom_distiller/content/BUILD.gn +++ b/components/dom_distiller/content/BUILD.gn @@ -14,8 +14,10 @@ if (!is_ios) { "web_contents_main_frame_observer.h", ] - deps = [ + public_deps = [ "//components/dom_distiller/core", + ] + deps = [ "//components/resources", "//components/strings", "//content/public/browser", @@ -23,9 +25,5 @@ if (!is_ios) { "//skia", "//sync", ] - - forward_dependent_configs_from = [ - "//components/dom_distiller/core", - ] } } diff --git a/components/dom_distiller/core/BUILD.gn b/components/dom_distiller/core/BUILD.gn index 8f9a7a6..e20a4ad 100644 --- a/components/dom_distiller/core/BUILD.gn +++ b/components/dom_distiller/core/BUILD.gn @@ -46,25 +46,22 @@ static_library("core") { "viewer.h", ] + public_deps = [ + "//components/dom_distiller/core/proto", + "//third_party/dom_distiller_js:proto", + ] deps = [ "//base", - "//components/dom_distiller/core/proto", "//components/leveldb_proto", "//components/resources", "//components/strings", "//net", "//skia", "//sync", - "//third_party/dom_distiller_js:proto", "//ui/base", "//url", ] - forward_dependent_configs_from = [ - "//components/dom_distiller/core/proto", - "//third_party/dom_distiller_js:proto", - ] - if (is_android) { deps += [ ":jni_headers" ] } diff --git a/components/infobars/core/BUILD.gn b/components/infobars/core/BUILD.gn index 6de274b..44330ce 100644 --- a/components/infobars/core/BUILD.gn +++ b/components/infobars/core/BUILD.gn @@ -19,13 +19,12 @@ static_library("core") { "infobars_switches.h", ] + public_deps = [ + "//skia", + ] deps = [ "//base", - "//skia", "//ui/gfx", "//ui/strings", ] - - # This target exposes Skia headers in its public headers. - forward_dependent_configs_from = [ "//skia" ] } diff --git a/components/invalidation/BUILD.gn b/components/invalidation/BUILD.gn index 6ab8569..c1e581b 100644 --- a/components/invalidation/BUILD.gn +++ b/components/invalidation/BUILD.gn @@ -76,6 +76,9 @@ static_library("invalidation") { ] } + public_deps = [ + "//third_party/cacheinvalidation", + ] deps = [ "//base", "//components/gcm_driver", @@ -84,16 +87,11 @@ static_library("invalidation") { "//components/signin/core/browser", "//google_apis", "//jingle:notifier", - "//third_party/cacheinvalidation", # TODO(sync): Remove this (http://crbug.com/133352); "//third_party/protobuf:protobuf_lite", # "//third_party/cacheinvalidation/src/google/cacheinvalidation:cacheinvalidation_proto_cpp", ] - - forward_dependent_configs_from = [ - "//third_party/cacheinvalidation", - ] } static_library("test_support") { diff --git a/components/metrics/BUILD.gn b/components/metrics/BUILD.gn index 685788c..617c691 100644 --- a/components/metrics/BUILD.gn +++ b/components/metrics/BUILD.gn @@ -44,14 +44,14 @@ source_set("metrics") { "persisted_logs.h", ] + public_deps = [ + "//components/metrics/proto", + ] deps = [ "//base", - "//components/metrics/proto", "//components/variations", "//third_party/zlib", ] - - forward_dependent_configs_from = [ "//components/metrics/proto" ] } # GYP version: components/metrics.gypi:metrics_gpu @@ -61,12 +61,12 @@ source_set("gpu") { "gpu/gpu_metrics_provider.h", ] - deps = [ + public_deps = [ ":metrics", + ] + deps = [ "//gpu/config", ] - - forward_dependent_configs_from = [ ":metrics" ] } # GYP version: components/metrics.gypi:metrics_net @@ -82,12 +82,12 @@ static_library("net") { "net/wifi_access_point_info_provider_chromeos.h", ] - deps = [ + public_deps = [ ":metrics", + ] + deps = [ "//net", ] - - forward_dependent_configs_from = [ ":metrics" ] } # GYP version: components/metrics.gypi:metrics_profiler @@ -100,13 +100,13 @@ source_set("profiler") { "profiler/tracking_synchronizer_observer.h", ] - deps = [ + public_deps = [ ":metrics", + ] + deps = [ "//base", "//content/public/browser", ] - - forward_dependent_configs_from = [ ":metrics" ] } # GYP version: components/metrics.gypi:metrics_test_support @@ -116,11 +116,9 @@ static_library("test_support") { "test_metrics_service_client.h", ] - deps = [ + public_deps = [ ":metrics", ] - - forward_dependent_configs_from = [ ":metrics" ] } # TODO(GYP): metrics_chromeos diff --git a/components/omnibox/BUILD.gn b/components/omnibox/BUILD.gn index 2f56ee6..f24e05d 100644 --- a/components/omnibox/BUILD.gn +++ b/components/omnibox/BUILD.gn @@ -35,9 +35,11 @@ static_library("omnibox") { "url_prefix.h", ] + public_deps = [ + "//components/metrics/proto", + ] deps = [ "//base", - "//components/metrics/proto", "//components/resources", "//components/search_engines", "//components/strings", @@ -47,10 +49,6 @@ static_library("omnibox") { "//ui/base", "//url", ] - - forward_dependent_configs_from = [ - "//components/metrics/proto", - ] } static_library("test_support") { diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn index 27602164..d9cf8c0 100644 --- a/components/password_manager/core/browser/BUILD.gn +++ b/components/password_manager/core/browser/BUILD.gn @@ -79,7 +79,7 @@ static_library("browser") { cflags = [ "/wd4267" ] } - direct_dependent_configs = [ ":password_manager_config" ] + public_configs = [ ":password_manager_config" ] # Sync (not supported in Android WebView). if (!is_android || !is_android_webview_build) { @@ -106,15 +106,13 @@ source_set("test_support") { "test_password_store.h", ] - deps = [ + public_deps = [ ":browser", + ] + deps = [ "//base", "//components/autofill/core/common", "//testing/gmock", "//testing/gtest", ] - - forward_dependent_configs_from = [ - ":browser", - ] } |