summaryrefslogtreecommitdiffstats
path: root/components
diff options
context:
space:
mode:
authorbrettw <brettw@chromium.org>2015-05-19 16:14:33 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-19 23:15:38 +0000
commite97185bf4853d56aadf362b0a00699375b1fac76 (patch)
tree3ee6d81fc3bbc55221d253867dd5ee9bef414775 /components
parentb2a22fabff7df7b8fec9e168dc7eac1535c4d713 (diff)
downloadchromium_src-e97185bf4853d56aadf362b0a00699375b1fac76.zip
chromium_src-e97185bf4853d56aadf362b0a00699375b1fac76.tar.gz
chromium_src-e97185bf4853d56aadf362b0a00699375b1fac76.tar.bz2
Revert of Fix missing GN dependencies. (patchset #4 id:60001 of https://codereview.chromium.org/1128163007/)
Reason for revert: Broke Windows: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/steps/compile/logs/stdio Original issue's description: > Fix missing GN dependencies. > > Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency. > > json_schema_api.gni was generating wrong names, this was fixed. > > mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency. > > The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents. > > BUG=487897 > > Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 > Cr-Commit-Position: refs/heads/master@{#330636} TBR=dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487897 Review URL: https://codereview.chromium.org/1137693006 Cr-Commit-Position: refs/heads/master@{#330650}
Diffstat (limited to 'components')
-rw-r--r--components/html_viewer/BUILD.gn1
1 files changed, 0 insertions, 1 deletions
diff --git a/components/html_viewer/BUILD.gn b/components/html_viewer/BUILD.gn
index 1ce9f05..ec98f74 100644
--- a/components/html_viewer/BUILD.gn
+++ b/components/html_viewer/BUILD.gn
@@ -197,7 +197,6 @@ mojo_application_package("html_viewer") {
"$root_build_dir/natives_blob.bin",
"$root_build_dir/snapshot_blob.bin",
]
- deps += [ "//gin" ]
}
}