diff options
| author | brettw <brettw@chromium.org> | 2016-03-25 09:57:11 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-25 16:58:34 +0000 |
| commit | fc09b679eaa615029a0288fc202c7886aa49e278 (patch) | |
| tree | ac61f60142ee374100b41c81a37052abbc631acb /content/browser/BUILD.gn | |
| parent | 9be8ca7b77549c46f9a51e991d25e1a509664fd5 (diff) | |
| download | chromium_src-fc09b679eaa615029a0288fc202c7886aa49e278.zip chromium_src-fc09b679eaa615029a0288fc202c7886aa49e278.tar.gz chromium_src-fc09b679eaa615029a0288fc202c7886aa49e278.tar.bz2 | |
Revert of Content "gn check" work. (patchset #10 id:180001 of https://codereview.chromium.org/1828483002/ )
Reason for revert:
Broke https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19740/steps/compile/logs/stdio
Original issue's description:
> Content "gn check" work.
>
> Make content/gpu and content/plugin pass GN check.
>
> Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.
>
> The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn
>
> Renames the ui/events/ipc according to GN style
>
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
> TBR=jschuh (IPC build tweak)
>
> Committed: https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400
> Cr-Commit-Position: refs/heads/master@{#383208}
TBR=jam@chromium.org,jschuh@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1836533002
Cr-Commit-Position: refs/heads/master@{#383289}
Diffstat (limited to 'content/browser/BUILD.gn')
| -rw-r--r-- | content/browser/BUILD.gn | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn index fcd1572..9245309 100644 --- a/content/browser/BUILD.gn +++ b/content/browser/BUILD.gn @@ -11,10 +11,7 @@ import("//mojo/public/mojo_application_manifest.gni") source_set("browser") { # Only the public target should depend on this. All other targets (even # internal content ones) should depend on the public one. - visibility = [ - ":for_content_tests", - "//content/public/browser:browser_sources", - ] + visibility = [ "//content/public/browser:browser_sources" ] configs += [ "//build/config:precompiled_headers", @@ -529,16 +526,6 @@ source_set("browser") { } } -# See comment at the top of //content/BUILD.gn for how this works. -group("for_content_tests") { - visibility = [ "//content/test/*" ] - if (!is_component_build) { - public_deps = [ - ":browser", - ] - } -} - mojo_application_manifest("chrome_manifest") { type = "exe" application_name = "chrome" |