summaryrefslogtreecommitdiffstats
path: root/content/browser/accessibility
diff options
context:
space:
mode:
authorjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-22 19:05:05 +0000
committerjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-22 19:05:05 +0000
commit446c1a30aa216ec0c01f056836532f602065c128 (patch)
treed0d660b8616f0b4d3aed2db1a095f789cfb9a597 /content/browser/accessibility
parentba320bf1caadbd3ba24d2211bbc73d20c41b26f8 (diff)
downloadchromium_src-446c1a30aa216ec0c01f056836532f602065c128.zip
chromium_src-446c1a30aa216ec0c01f056836532f602065c128.tar.gz
chromium_src-446c1a30aa216ec0c01f056836532f602065c128.tar.bz2
Clean up a few TODO items.
Push UnhandledWheelEvent and GetBrowserAccessibilityManager down to RenderWidgetHostViewPort. Get rid of OnMessageReceivedForTesting, in favor of RenderViewHostTester::TestOnMessageReceived (which already existed but needed to be converted to a static method so it could be used with regular RenderViewHost instances). Rename WebContentsTester::pending_rvh() to GetPendingRvh() since it's a virtual method. Remove top-level alias for content::RenderViewHostTestHarness and switch clients to use the fully-qualified name. Clean up a couple of other minor TODO items, some had already been done and the comment just needed to be removed; in one case the TODO was just wrong (in dump_accessibility_tree_browsertest.cc) since it's OK for content to depend on content implementations. Remove test_tab_contents.h from DEPS (seems to have been a merge failure in my last change that left this in). BUG=98716 Review URL: http://codereview.chromium.org/9838009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128263 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/accessibility')
-rw-r--r--content/browser/accessibility/dump_accessibility_tree_browsertest.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 89e96a4..786962d 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -17,9 +17,9 @@
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/accessibility/dump_accessibility_tree_helper.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
+#include "content/port/browser/render_widget_host_view_port.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
-#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_paths.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -28,6 +28,7 @@ using content::OpenURLParams;
using content::RenderViewHostImpl;
using content::RenderWidgetHostImpl;
using content::RenderWidgetHost;
+using content::RenderWidgetHostViewPort;
using content::Referrer;
namespace {
@@ -76,10 +77,9 @@ class DumpAccessibilityTreeTest : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
PlatformTreeDifferenceTest) {
- content::RenderWidgetHostView* host_view =
- browser()->GetSelectedWebContents()->GetRenderWidgetHostView();
+ RenderWidgetHostViewPort* host_view = static_cast<RenderWidgetHostViewPort*>(
+ browser()->GetSelectedWebContents()->GetRenderWidgetHostView());
RenderWidgetHost* host = host_view->GetRenderWidgetHost();
- // TODO(joi): Remove this dependency
RenderViewHostImpl* view_host =
static_cast<RenderViewHostImpl*>(RenderWidgetHostImpl::From(host));
view_host->set_save_accessibility_tree_for_testing(true);