diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-20 23:17:06 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-20 23:17:06 +0000 |
commit | 4587873229fd72441369dad26e131959385c92ec (patch) | |
tree | e480f6ec5ba347c794d981f26ae3757a86687877 /content/browser/accessibility | |
parent | 2ef28514801ab44203e9f31efc7b4d667eb2f75d (diff) | |
download | chromium_src-4587873229fd72441369dad26e131959385c92ec.zip chromium_src-4587873229fd72441369dad26e131959385c92ec.tar.gz chromium_src-4587873229fd72441369dad26e131959385c92ec.tar.bz2 |
Invoke the inactive frame rendering code in WM_WINDOWPOSCHANGING instead of WM_WINDOWPOSCHANGED.
This ensures that we can draw the caption as active in the browser frame before it loses activation. This
also alleviates the need to send a fake WM_NCACTIVATE message from the DesktopRootWindowHost, which has
sideeffects as seen in bug https://code.google.com/p/chromium/issues/detail?id=273194 where the extension popup
shows up and destroys itself when the browser frame is activated via the sent WM_NCCACTIVATE message.
Changes in this CL are as below:-
1. Removed the virtual function SetInactiveRenderingDisabled from the DesktopRootWindowHost interface.
2. Added a new virtual function HandleVisibilityChanging to the HWNDMessageHandlerDelegate interface.
This is invoked from the HWNDMessageHandler::OnWindowPosChanging function.
3. Added a new virtual function OnNativeWidgetVisibilityChanging to the NativeWidgetDelegate interface and
the corresponding implementation in the widget. This fires the OnWidgetVisibilityChanging notification
on the WidgetObserver which is implemented by the BubbleDelegate.
3. Read the delegate_->IsInactiveRenderingDisabled result at the beginning of the HWNDMessageHandler::OnNCActivate
function. This is needed because the delegate_->HandleActivationChanged call resets the inactive rendering flag.
Tested this with avatar bubble/extension popups in glass/classic mode. Works well.
BUG=273194
R=sky@chromium.org
Review URL: https://codereview.chromium.org/23072016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218568 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/accessibility')
0 files changed, 0 insertions, 0 deletions