summaryrefslogtreecommitdiffstats
path: root/content/browser/appcache
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2015-12-25 22:16:36 -0800
committerCommit bot <commit-bot@chromium.org>2015-12-26 06:17:30 +0000
commit36b6aec9a5f4953e2177146503096ca7de00cc36 (patch)
treea1d68bc1fab0b8127d7f47d3f9b3550eada5ac15 /content/browser/appcache
parent2729e442b1172c5094503a03fe356c8580bb919d (diff)
downloadchromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.zip
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.gz
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.bz2
Convert Pass()→std::move() in //content/browser
BUG=557422 Review URL: https://codereview.chromium.org/1545243002 Cr-Commit-Position: refs/heads/master@{#366894}
Diffstat (limited to 'content/browser/appcache')
-rw-r--r--content/browser/appcache/appcache_disk_cache.cc3
-rw-r--r--content/browser/appcache/appcache_request_handler.cc5
-rw-r--r--content/browser/appcache/appcache_request_handler_unittest.cc9
-rw-r--r--content/browser/appcache/appcache_service_impl.cc7
-rw-r--r--content/browser/appcache/appcache_storage_impl_unittest.cc12
-rw-r--r--content/browser/appcache/appcache_update_job_unittest.cc6
6 files changed, 25 insertions, 17 deletions
diff --git a/content/browser/appcache/appcache_disk_cache.cc b/content/browser/appcache/appcache_disk_cache.cc
index f7cbc58..49030f0 100644
--- a/content/browser/appcache/appcache_disk_cache.cc
+++ b/content/browser/appcache/appcache_disk_cache.cc
@@ -5,6 +5,7 @@
#include "content/browser/appcache/appcache_disk_cache.h"
#include <limits>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -369,7 +370,7 @@ int AppCacheDiskCache::Init(
void AppCacheDiskCache::OnCreateBackendComplete(int rv) {
if (rv == net::OK) {
- disk_cache_ = create_backend_callback_->backend_ptr_.Pass();
+ disk_cache_ = std::move(create_backend_callback_->backend_ptr_);
}
create_backend_callback_ = NULL;
diff --git a/content/browser/appcache/appcache_request_handler.cc b/content/browser/appcache/appcache_request_handler.cc
index a2d7c48..c022237 100644
--- a/content/browser/appcache/appcache_request_handler.cc
+++ b/content/browser/appcache/appcache_request_handler.cc
@@ -4,6 +4,8 @@
#include "content/browser/appcache/appcache_request_handler.h"
+#include <utility>
+
#include "base/bind.h"
#include "content/browser/appcache/appcache.h"
#include "content/browser/appcache/appcache_backend_impl.h"
@@ -197,7 +199,8 @@ void AppCacheRequestHandler::CompleteCrossSiteTransfer(
return;
DCHECK_EQ(host_, host_for_cross_site_transfer_.get());
AppCacheBackendImpl* backend = host_->service()->GetBackend(new_process_id);
- backend->TransferHostIn(new_host_id, host_for_cross_site_transfer_.Pass());
+ backend->TransferHostIn(new_host_id,
+ std::move(host_for_cross_site_transfer_));
}
void AppCacheRequestHandler::MaybeCompleteCrossSiteTransferInOldProcess(
diff --git a/content/browser/appcache/appcache_request_handler_unittest.cc b/content/browser/appcache/appcache_request_handler_unittest.cc
index 4a677f2..46ce987 100644
--- a/content/browser/appcache/appcache_request_handler_unittest.cc
+++ b/content/browser/appcache/appcache_request_handler_unittest.cc
@@ -2,10 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <stdint.h>
+#include "content/browser/appcache/appcache_request_handler.h"
+#include <stdint.h>
#include <stack>
#include <string>
+#include <utility>
#include <vector>
#include "base/bind.h"
@@ -20,7 +22,6 @@
#include "base/threading/thread.h"
#include "content/browser/appcache/appcache.h"
#include "content/browser/appcache/appcache_backend_impl.h"
-#include "content/browser/appcache/appcache_request_handler.h"
#include "content/browser/appcache/appcache_url_request_job.h"
#include "content/browser/appcache/mock_appcache_policy.h"
#include "content/browser/appcache/mock_appcache_service.h"
@@ -119,7 +120,7 @@ class AppCacheRequestHandlerTest : public testing::Test {
~MockURLRequestJobFactory() override { DCHECK(!job_); }
- void SetJob(scoped_ptr<net::URLRequestJob> job) { job_ = job.Pass(); }
+ void SetJob(scoped_ptr<net::URLRequestJob> job) { job_ = std::move(job); }
net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
const std::string& scheme,
@@ -816,7 +817,7 @@ class AppCacheRequestHandlerTest : public testing::Test {
base::WeakPtr<AppCacheURLRequestJob> weak_job = job_->GetWeakPtr();
- job_factory_->SetJob(job_.Pass());
+ job_factory_->SetJob(std::move(job_));
request_->Start();
ASSERT_TRUE(weak_job);
EXPECT_TRUE(weak_job->has_been_started());
diff --git a/content/browser/appcache/appcache_service_impl.cc b/content/browser/appcache/appcache_service_impl.cc
index fd8c686..2fc5d94 100644
--- a/content/browser/appcache/appcache_service_impl.cc
+++ b/content/browser/appcache/appcache_service_impl.cc
@@ -5,6 +5,7 @@
#include "content/browser/appcache/appcache_service_impl.h"
#include <functional>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -389,7 +390,7 @@ void AppCacheServiceImpl::CheckResponseHelper::OnReadDataComplete(int result) {
AppCacheStorageReference::AppCacheStorageReference(
scoped_ptr<AppCacheStorage> storage)
- : storage_(storage.Pass()) {}
+ : storage_(std::move(storage)) {}
AppCacheStorageReference::~AppCacheStorageReference() {}
// AppCacheServiceImpl -------
@@ -469,8 +470,8 @@ void AppCacheServiceImpl::Reinitialize() {
// Inform observers of about this and give them a chance to
// defer deletion of the old storage object.
- scoped_refptr<AppCacheStorageReference>
- old_storage_ref(new AppCacheStorageReference(storage_.Pass()));
+ scoped_refptr<AppCacheStorageReference> old_storage_ref(
+ new AppCacheStorageReference(std::move(storage_)));
FOR_EACH_OBSERVER(Observer, observers_,
OnServiceReinitialized(old_storage_ref.get()));
diff --git a/content/browser/appcache/appcache_storage_impl_unittest.cc b/content/browser/appcache/appcache_storage_impl_unittest.cc
index 1a80274..9e4c2c4 100644
--- a/content/browser/appcache/appcache_storage_impl_unittest.cc
+++ b/content/browser/appcache/appcache_storage_impl_unittest.cc
@@ -2,9 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <stdint.h>
+#include "content/browser/appcache/appcache_storage_impl.h"
+#include <stdint.h>
#include <stack>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -27,7 +29,6 @@
#include "content/browser/appcache/appcache_interceptor.h"
#include "content/browser/appcache/appcache_request_handler.h"
#include "content/browser/appcache/appcache_service_impl.h"
-#include "content/browser/appcache/appcache_storage_impl.h"
#include "net/base/net_errors.h"
#include "net/base/request_priority.h"
#include "net/http/http_response_headers.h"
@@ -132,9 +133,8 @@ class MockHttpServerJobFactory
: public net::URLRequestJobFactory::ProtocolHandler {
public:
MockHttpServerJobFactory(
- scoped_ptr<net::URLRequestInterceptor> appcache_start_interceptor)
- : appcache_start_interceptor_(appcache_start_interceptor.Pass()) {
- }
+ scoped_ptr<net::URLRequestInterceptor> appcache_start_interceptor)
+ : appcache_start_interceptor_(std::move(appcache_start_interceptor)) {}
net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
@@ -168,7 +168,7 @@ class IOThread : public base::Thread {
factory->SetProtocolHandler(
"http", make_scoped_ptr(new MockHttpServerJobFactory(
make_scoped_ptr(new AppCacheInterceptor()))));
- job_factory_ = factory.Pass();
+ job_factory_ = std::move(factory);
request_context_.reset(new net::TestURLRequestContext());
request_context_->set_job_factory(job_factory_.get());
}
diff --git a/content/browser/appcache/appcache_update_job_unittest.cc b/content/browser/appcache/appcache_update_job_unittest.cc
index 39c2290..9820bc2 100644
--- a/content/browser/appcache/appcache_update_job_unittest.cc
+++ b/content/browser/appcache/appcache_update_job_unittest.cc
@@ -2,8 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "content/browser/appcache/appcache_update_job.h"
+
#include <stddef.h>
#include <stdint.h>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -17,7 +20,6 @@
#include "content/browser/appcache/appcache_group.h"
#include "content/browser/appcache/appcache_host.h"
#include "content/browser/appcache/appcache_response.h"
-#include "content/browser/appcache/appcache_update_job.h"
#include "content/browser/appcache/mock_appcache_service.h"
#include "net/base/net_errors.h"
#include "net/http/http_response_headers.h"
@@ -582,7 +584,7 @@ class IOThread : public base::Thread {
make_scoped_ptr(new MockHttpServerJobFactory));
factory->SetProtocolHandler("https",
make_scoped_ptr(new MockHttpServerJobFactory));
- job_factory_ = factory.Pass();
+ job_factory_ = std::move(factory);
request_context_.reset(new net::TestURLRequestContext());
request_context_->set_job_factory(job_factory_.get());
}