diff options
| author | fsamuel <fsamuel@chromium.org> | 2015-02-24 17:25:44 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-25 01:27:00 +0000 |
| commit | 2e9413d8e27666cdd7961b5d17e7cb270bc48fc1 (patch) | |
| tree | 32a85a2e106378f951d0efa42dcb6f2b528a3a72 /content/browser/browser_plugin/browser_plugin_embedder.cc | |
| parent | 08b8639e0a7c0db180bf6ff8e2a4c54b103df3ef (diff) | |
| download | chromium_src-2e9413d8e27666cdd7961b5d17e7cb270bc48fc1.zip chromium_src-2e9413d8e27666cdd7961b5d17e7cb270bc48fc1.tar.gz chromium_src-2e9413d8e27666cdd7961b5d17e7cb270bc48fc1.tar.bz2 | |
Decouple BrowserPlugin from RenderView
With the move to out-of-process iframes, RenderFrames and away from RenderViews, this CL removes routing via RenderView Routing ID from BrowserPlugin.
Aside from BrowserPluginHostMsg_Attach, which creates a new BrowserPluginEmbedder in the associated WebContents on first call, all other IPCs are now CONTROL because they do not rely on routing IDs.
BUG=436339, 330264
TBR=kenrb@chromium.org for mechanical change to make all BrowserPluginHostMsg IPCs except ATTACH CONTROL instead of ROUTED.
Review URL: https://codereview.chromium.org/929243003
Cr-Commit-Position: refs/heads/master@{#317940}
Diffstat (limited to 'content/browser/browser_plugin/browser_plugin_embedder.cc')
| -rw-r--r-- | content/browser/browser_plugin/browser_plugin_embedder.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc index acb72f0..28aa57f 100644 --- a/content/browser/browser_plugin/browser_plugin_embedder.cc +++ b/content/browser/browser_plugin/browser_plugin_embedder.cc @@ -151,12 +151,9 @@ void BrowserPluginEmbedder::OnAttach( RenderFrameHost* render_frame_host, int browser_plugin_instance_id, const BrowserPluginHostMsg_Attach_Params& params) { - // TODO(fsamuel): Change message routing to use the process ID of the - // |render_frame_host| once BrowserPlugin IPCs get routed using the RFH - // routing ID. See http://crbug.com/436339. WebContents* guest_web_contents = GetBrowserPluginGuestManager()->GetGuestByInstanceID( - web_contents()->GetRenderProcessHost()->GetID(), + render_frame_host->GetProcess()->GetID(), browser_plugin_instance_id); if (!guest_web_contents) return; |