diff options
| author | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-14 19:14:42 +0000 |
|---|---|---|
| committer | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-14 19:14:42 +0000 |
| commit | f9feef3e16ca7e95cbd0e1a1586ed443f5686b42 (patch) | |
| tree | 635cb572806c5943634c52e4ce1067e077ac8a02 /content/browser/byte_stream.cc | |
| parent | 1a29357b3d468e5136c596f7ee92660b40968f4b (diff) | |
| download | chromium_src-f9feef3e16ca7e95cbd0e1a1586ed443f5686b42.zip chromium_src-f9feef3e16ca7e95cbd0e1a1586ed443f5686b42.tar.gz chromium_src-f9feef3e16ca7e95cbd0e1a1586ed443f5686b42.tar.bz2 | |
Explain the reason why we don't have thread check in destructor of ByteStreamReader/Writer.
They can be deleted before being used and it's safe to do so.
Review URL: https://codereview.chromium.org/22925003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257173 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/byte_stream.cc')
| -rw-r--r-- | content/browser/byte_stream.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/content/browser/byte_stream.cc b/content/browser/byte_stream.cc index 7b0f9fb..0cd3cd8 100644 --- a/content/browser/byte_stream.cc +++ b/content/browser/byte_stream.cc @@ -194,6 +194,9 @@ ByteStreamWriterImpl::ByteStreamWriterImpl( } ByteStreamWriterImpl::~ByteStreamWriterImpl() { + // No RunsTasksOnCurrentThread() check to allow deleting a created writer + // before we start using it. Once started, should be deleted on the specified + // task runner. my_lifetime_flag_->is_alive = false; } @@ -323,6 +326,9 @@ ByteStreamReaderImpl::ByteStreamReaderImpl( } ByteStreamReaderImpl::~ByteStreamReaderImpl() { + // No RunsTasksOnCurrentThread() check to allow deleting a created writer + // before we start using it. Once started, should be deleted on the specified + // task runner. my_lifetime_flag_->is_alive = false; } |