summaryrefslogtreecommitdiffstats
path: root/content/browser/debugger
diff options
context:
space:
mode:
authordpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-27 01:18:28 +0000
committerdpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-27 01:18:28 +0000
commitae6e99198cc1d63e74459ba60172676bcea2af22 (patch)
tree13fa083e1a8b2b60e6038b495b62e9e32fdde3eb /content/browser/debugger
parentcf4b8e3ace0b430a3bb73d45a3af0a146b0d846e (diff)
downloadchromium_src-ae6e99198cc1d63e74459ba60172676bcea2af22.zip
chromium_src-ae6e99198cc1d63e74459ba60172676bcea2af22.tar.gz
chromium_src-ae6e99198cc1d63e74459ba60172676bcea2af22.tar.bz2
Remove ChromeNetLog depenency from content/browser/debugger
Revert r94208 (re-land r94196), add missing NET_API decl. TBR=willchan@chromium.org BUG=84078 TEST=everything compiles Review URL: http://codereview.chromium.org/7477035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94227 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/debugger')
-rw-r--r--content/browser/debugger/DEPS6
-rw-r--r--content/browser/debugger/devtools_manager.cc3
-rw-r--r--content/browser/debugger/devtools_netlog_observer.cc19
-rw-r--r--content/browser/debugger/devtools_netlog_observer.h15
4 files changed, 19 insertions, 24 deletions
diff --git a/content/browser/debugger/DEPS b/content/browser/debugger/DEPS
index 558fbbd..db358e1 100644
--- a/content/browser/debugger/DEPS
+++ b/content/browser/debugger/DEPS
@@ -9,15 +9,11 @@ include_rules = [
# devtools_manager.cc, http://codereview.chromium.org/7310029/
"+chrome/browser/browser_process.h",
- "+chrome/browser/net/chrome_net_log.h",
-
- # devtools_net_log_observer.cc
- "+chrome/browser/io_thread.h",
# worker_devtools_manager_io.cc
"+chrome/browser/debugger/devtools_window.h",
"+chrome/browser/profiles/profile_manager.h",
-
+
# devtools_http_protocol_handler.cc
"+ui/base/resource/resource_bundle.h",
"+chrome/browser/ui/webui/devtools_ui.h",
diff --git a/content/browser/debugger/devtools_manager.cc b/content/browser/debugger/devtools_manager.cc
index bc8d4f9..c79aee7 100644
--- a/content/browser/debugger/devtools_manager.cc
+++ b/content/browser/debugger/devtools_manager.cc
@@ -247,8 +247,7 @@ void DevToolsManager::BindClientHost(
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
- NewRunnableFunction(&DevToolsNetLogObserver::Attach,
- g_browser_process->io_thread()));
+ NewRunnableFunction(&DevToolsNetLogObserver::Attach));
}
inspected_rvh_to_client_host_[inspected_rvh] = client_host;
client_host_to_inspected_rvh_[client_host] = inspected_rvh;
diff --git a/content/browser/debugger/devtools_netlog_observer.cc b/content/browser/debugger/devtools_netlog_observer.cc
index 919c53c..9e278b0 100644
--- a/content/browser/debugger/devtools_netlog_observer.cc
+++ b/content/browser/debugger/devtools_netlog_observer.cc
@@ -7,7 +7,8 @@
#include "base/string_tokenizer.h"
#include "base/string_util.h"
#include "base/values.h"
-#include "chrome/browser/io_thread.h"
+#include "content/browser/browser_thread.h"
+#include "content/browser/content_browser_client.h"
#include "content/common/resource_response.h"
#include "net/base/load_flags.h"
#include "net/http/http_net_log_params.h"
@@ -21,14 +22,14 @@ const size_t kMaxNumEntries = 1000;
DevToolsNetLogObserver* DevToolsNetLogObserver::instance_ = NULL;
-DevToolsNetLogObserver::DevToolsNetLogObserver(ChromeNetLog* chrome_net_log)
- : ChromeNetLog::ThreadSafeObserver(net::NetLog::LOG_ALL_BUT_BYTES),
- chrome_net_log_(chrome_net_log) {
- chrome_net_log_->AddObserver(this);
+DevToolsNetLogObserver::DevToolsNetLogObserver(net::NetLog* net_log)
+ : net::NetLog::ThreadSafeObserver(net::NetLog::LOG_ALL_BUT_BYTES),
+ net_log_(net_log) {
+ net_log_->AddThreadSafeObserver(this);
}
DevToolsNetLogObserver::~DevToolsNetLogObserver() {
- chrome_net_log_->RemoveObserver(this);
+ net_log_->RemoveThreadSafeObserver(this);
}
DevToolsNetLogObserver::ResourceInfo*
@@ -235,11 +236,11 @@ void DevToolsNetLogObserver::OnAddSocketEntry(
}
}
-void DevToolsNetLogObserver::Attach(IOThread* io_thread) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+void DevToolsNetLogObserver::Attach() {
DCHECK(!instance_);
- instance_ = new DevToolsNetLogObserver(io_thread->net_log());
+ instance_ = new DevToolsNetLogObserver(
+ content::GetContentClient()->browser()->GetNetLog());
}
void DevToolsNetLogObserver::Detach() {
diff --git a/content/browser/debugger/devtools_netlog_observer.h b/content/browser/debugger/devtools_netlog_observer.h
index 75b3314..3fe2765 100644
--- a/content/browser/debugger/devtools_netlog_observer.h
+++ b/content/browser/debugger/devtools_netlog_observer.h
@@ -8,14 +8,13 @@
#include "base/hash_tables.h"
#include "base/memory/ref_counted.h"
-#include "chrome/browser/net/chrome_net_log.h"
+#include "net/base/net_log.h"
#include "webkit/glue/resource_loader_bridge.h"
namespace net {
class URLRequest;
} // namespace net
-class IOThread;
struct ResourceResponse;
// DevToolsNetLogObserver watches the NetLog event stream and collects the
@@ -25,16 +24,16 @@ struct ResourceResponse;
// As DevToolsNetLogObserver shares live data with objects that live on the
// IO Thread, it must also reside on the IO Thread. Only OnAddEntry can be
// called from other threads.
-class DevToolsNetLogObserver: public ChromeNetLog::ThreadSafeObserver {
+class DevToolsNetLogObserver : public net::NetLog::ThreadSafeObserver {
typedef webkit_glue::ResourceDevToolsInfo ResourceInfo;
public:
- // ThreadSafeObserver implementation:
+ // net::NetLog::ThreadSafeObserver implementation:
virtual void OnAddEntry(net::NetLog::EventType type,
const base::TimeTicks& time,
const net::NetLog::Source& source,
net::NetLog::EventPhase phase,
- net::NetLog::EventParameters* params);
+ net::NetLog::EventParameters* params) OVERRIDE;
void OnAddURLRequestEntry(net::NetLog::EventType type,
const base::TimeTicks& time,
@@ -54,7 +53,7 @@ class DevToolsNetLogObserver: public ChromeNetLog::ThreadSafeObserver {
net::NetLog::EventPhase phase,
net::NetLog::EventParameters* params);
- static void Attach(IOThread* thread);
+ static void Attach();
static void Detach();
// Must be called on the IO thread. May return NULL if no observers
@@ -66,12 +65,12 @@ class DevToolsNetLogObserver: public ChromeNetLog::ThreadSafeObserver {
private:
static DevToolsNetLogObserver* instance_;
- explicit DevToolsNetLogObserver(ChromeNetLog* chrome_net_log);
+ explicit DevToolsNetLogObserver(net::NetLog* net_log);
virtual ~DevToolsNetLogObserver();
ResourceInfo* GetResourceInfo(uint32 id);
- ChromeNetLog* chrome_net_log_;
+ net::NetLog* net_log_;
typedef base::hash_map<uint32, scoped_refptr<ResourceInfo> > RequestToInfoMap;
typedef base::hash_map<uint32, int> RequestToEncodedDataLengthMap;
typedef base::hash_map<uint32, uint32> HTTPStreamJobToSocketMap;