diff options
| author | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-11 17:51:00 +0000 |
|---|---|---|
| committer | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-11 17:51:00 +0000 |
| commit | 32ad6b4358054a3436378517d7659f48d44cf9ec (patch) | |
| tree | b1ad22b845307388955a506bc17f252173246366 /content/browser/devtools/devtools_http_handler_impl.cc | |
| parent | 08c6b1869c0d94a456fee80a3970d3f7453350e5 (diff) | |
| download | chromium_src-32ad6b4358054a3436378517d7659f48d44cf9ec.zip chromium_src-32ad6b4358054a3436378517d7659f48d44cf9ec.tar.gz chromium_src-32ad6b4358054a3436378517d7659f48d44cf9ec.tar.bz2 | |
Do not show pages of swapped out RenderViewHosts in DevTools remote debugging
RenderViewHosts can be swapped out for performance and cross-scripting
purposes (see the full discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/e-M4HgwpDp8/discussion)
It makes no sense reporting the corresponding views on DevTools remote
debugging landing pages.
Review URL: https://chromiumcodereview.appspot.com/12764008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187312 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/devtools/devtools_http_handler_impl.cc')
| -rw-r--r-- | content/browser/devtools/devtools_http_handler_impl.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc index 665d01f..6a77878 100644 --- a/content/browser/devtools/devtools_http_handler_impl.cc +++ b/content/browser/devtools/devtools_http_handler_impl.cc @@ -22,6 +22,7 @@ #include "content/browser/devtools/devtools_agent_host_impl.h" #include "content/browser/devtools/devtools_browser_target.h" #include "content/browser/devtools/devtools_tracing_handler.h" +#include "content/browser/renderer_host/render_view_host_impl.h" #include "content/browser/web_contents/web_contents_impl.h" #include "content/common/devtools_messages.h" #include "content/public/browser/browser_thread.h" @@ -436,6 +437,10 @@ DevToolsHttpHandlerImpl::PageList DevToolsHttpHandlerImpl::GeneratePageList() { RenderViewHost* host = RenderViewHost::From(const_cast<RenderWidgetHost*>(widget)); + // Don't report swapped out views. + if (static_cast<RenderViewHostImpl*>(host)->is_swapped_out()) + continue; + page_list.push_back(CreatePageInfo(host, delegate_->GetTargetType(host))); } } |