diff options
| author | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-28 18:36:09 +0000 |
|---|---|---|
| committer | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-28 18:36:09 +0000 |
| commit | f1d784d6938b8fe8e0d257e41b26341992c2552c (patch) | |
| tree | e8a57be7f78ffa26e886c5814d989d0a8da3893d /content/browser/download/download_item_impl.h | |
| parent | 3c919d6ac5b262904d6598fc2418d7c0358aad57 (diff) | |
| download | chromium_src-f1d784d6938b8fe8e0d257e41b26341992c2552c.zip chromium_src-f1d784d6938b8fe8e0d257e41b26341992c2552c.tar.gz chromium_src-f1d784d6938b8fe8e0d257e41b26341992c2552c.tar.bz2 | |
A few minor changes to the chrome.downloads extension API
Reviewers:
jhawkins: webui
Done:
asanka: */download/*
jam: content/public/*
asargent: */extensions/*
Replaced the "Invalid operation" error message with more specific and helpful messages
Add DownloadItem.referrer
Add DownloadItem.estimatedEndTime
Add DownloadItem.canResume
Change DownloadQuery.limit to default to 1000
Change 'conflict_action' to 'conflictAction'.
Change DownloadQuery.orderBy and DownloadQuery.query to arrays of strings
Remove DownloadItem.dangerAccepted in favor of DownloadItem.danger == 'accepted'
Add showDefaultFolder().
Disallow access to packaged_apps.
download() now updates the Download.Sources histogram. http://crbug.com/240322
Document using startedAfter and limit to page through search() results.
DownloadItem.error is now a string enum instead of mysterious numbers.
Add downloads.removeFile(id) and DownloadItem::DeleteFile() so that the file may be deleted separately from the history entry.
Calling open() for dangerous downloads has always been guaranteed to return kInvalidOperation because unaccepted dangerous downloads cannot transition to state='complete', and open() returns kInvalidOperation for incomplete items.
We can wait until after launch to figure out whether there needs to be some mechanism to allow extensions to override the request header blacklist. This seems like an edge case for which we may never receive feature requests.
Staged docs preview: http://basho.cam.corp.google.com:8000/extensions/downloads.html#type-DownloadItem
BUG=240322
R=asanka@chromium.org, asargent@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/16924017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214133 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download/download_item_impl.h')
| -rw-r--r-- | content/browser/download/download_item_impl.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h index b57bae0..ac260b1 100644 --- a/content/browser/download/download_item_impl.h +++ b/content/browser/download/download_item_impl.h @@ -127,6 +127,7 @@ class CONTENT_EXPORT DownloadItemImpl virtual const std::string& GetHash() const OVERRIDE; virtual const std::string& GetHashState() const OVERRIDE; virtual bool GetFileExternallyRemoved() const OVERRIDE; + virtual void DeleteFile() OVERRIDE; virtual bool IsDangerous() const OVERRIDE; virtual DownloadDangerType GetDangerType() const OVERRIDE; virtual bool TimeRemaining(base::TimeDelta* remaining) const OVERRIDE; |