diff options
| author | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-18 18:24:43 +0000 |
|---|---|---|
| committer | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-18 18:24:43 +0000 |
| commit | 5461067e0985187cc8b01043c2b57ef242ff2f6c (patch) | |
| tree | 6d40a37bb0bacf7447d994654f183c8b504c61d8 /content/browser/download/save_package.cc | |
| parent | 5133bc4309b20528491db2d507c5ffdd02df98ae (diff) | |
| download | chromium_src-5461067e0985187cc8b01043c2b57ef242ff2f6c.zip chromium_src-5461067e0985187cc8b01043c2b57ef242ff2f6c.tar.gz chromium_src-5461067e0985187cc8b01043c2b57ef242ff2f6c.tar.bz2 | |
Revert 92870 - Modified cancel and interrupt processing to avoid race with history.
Avoid racing with the history callback by unilaterally removing
DownloadItem from queues on cancel/interrupt. This keeps the
state<->queue correspondence cleaner, and avoids leaving things on
queues during shutdown. It might also fix 85408; we'll see :-}.
BUG=85408
TEST=
Review URL: http://codereview.chromium.org/7294013
TBR=rdsmith@chromium.org
Review URL: http://codereview.chromium.org/7401024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92872 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download/save_package.cc')
| -rw-r--r-- | content/browser/download/save_package.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc index 0f05d9d..6420268 100644 --- a/content/browser/download/save_package.cc +++ b/content/browser/download/save_package.cc @@ -643,7 +643,7 @@ void SavePackage::Stop() { wait_state_ = FAILED; // Inform the DownloadItem we have canceled whole save page job. - download_->Cancel(); + download_->Cancel(false); } void SavePackage::CheckFinish() { |