summaryrefslogtreecommitdiffstats
path: root/content/browser/fileapi
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2015-12-25 22:16:36 -0800
committerCommit bot <commit-bot@chromium.org>2015-12-26 06:17:30 +0000
commit36b6aec9a5f4953e2177146503096ca7de00cc36 (patch)
treea1d68bc1fab0b8127d7f47d3f9b3550eada5ac15 /content/browser/fileapi
parent2729e442b1172c5094503a03fe356c8580bb919d (diff)
downloadchromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.zip
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.gz
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.bz2
Convert Pass()→std::move() in //content/browser
BUG=557422 Review URL: https://codereview.chromium.org/1545243002 Cr-Commit-Position: refs/heads/master@{#366894}
Diffstat (limited to 'content/browser/fileapi')
-rw-r--r--content/browser/fileapi/blob_reader_unittest.cc16
-rw-r--r--content/browser/fileapi/blob_storage_context_unittest.cc4
-rw-r--r--content/browser/fileapi/blob_url_request_job_unittest.cc6
-rw-r--r--content/browser/fileapi/browser_file_system_helper.cc11
-rw-r--r--content/browser/fileapi/chrome_blob_storage_context.cc12
-rw-r--r--content/browser/fileapi/copy_or_move_file_validator_unittest.cc13
-rw-r--r--content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc11
-rw-r--r--content/browser/fileapi/dragged_file_util_unittest.cc4
-rw-r--r--content/browser/fileapi/file_system_dir_url_request_job_unittest.cc7
-rw-r--r--content/browser/fileapi/file_system_operation_impl_write_unittest.cc6
-rw-r--r--content/browser/fileapi/file_system_operation_runner_unittest.cc10
-rw-r--r--content/browser/fileapi/file_system_url_request_job_unittest.cc7
-rw-r--r--content/browser/fileapi/file_writer_delegate_unittest.cc29
-rw-r--r--content/browser/fileapi/fileapi_message_filter.cc3
-rw-r--r--content/browser/fileapi/obfuscated_file_util_unittest.cc10
15 files changed, 77 insertions, 72 deletions
diff --git a/content/browser/fileapi/blob_reader_unittest.cc b/content/browser/fileapi/blob_reader_unittest.cc
index 66c5da6..d16b552 100644
--- a/content/browser/fileapi/blob_reader_unittest.cc
+++ b/content/browser/fileapi/blob_reader_unittest.cc
@@ -2,11 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "storage/browser/blob/blob_reader.h"
-
#include <stddef.h>
#include <stdint.h>
#include <string.h>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -29,6 +28,7 @@
#include "net/disk_cache/disk_cache.h"
#include "storage/browser/blob/blob_data_builder.h"
#include "storage/browser/blob/blob_data_handle.h"
+#include "storage/browser/blob/blob_reader.h"
#include "storage/browser/blob/blob_storage_context.h"
#include "storage/browser/fileapi/file_stream_reader.h"
#include "storage/browser/fileapi/file_system_context.h"
@@ -60,7 +60,7 @@ class EmptyDataHandle : public storage::BlobDataBuilder::DataHandle {
class DelayedReadEntry : public disk_cache::Entry {
public:
explicit DelayedReadEntry(disk_cache::ScopedEntryPtr entry)
- : entry_(entry.Pass()) {}
+ : entry_(std::move(entry)) {}
~DelayedReadEntry() override { EXPECT_FALSE(HasPendingReadCallbacks()); }
bool HasPendingReadCallbacks() { return !pending_read_callbacks_.empty(); }
@@ -154,7 +154,7 @@ scoped_ptr<disk_cache::Backend> CreateInMemoryDiskCache(
thread, nullptr, &cache, callback.callback());
EXPECT_EQ(net::OK, callback.GetResult(rv));
- return cache.Pass();
+ return cache;
}
disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
@@ -171,7 +171,7 @@ disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
rv = entry->WriteData(kTestDiskCacheStreamIndex, 0, iobuffer.get(),
iobuffer->size(), callback.callback(), false);
EXPECT_EQ(static_cast<int>(data.size()), callback.GetResult(rv));
- return entry.Pass();
+ return entry;
}
template <typename T>
@@ -325,10 +325,10 @@ class BlobReaderTest : public ::testing::Test {
protected:
void InitializeReader(BlobDataBuilder* builder) {
- blob_handle_ = builder ? context_.AddFinishedBlob(builder).Pass() : nullptr;
+ blob_handle_ = builder ? context_.AddFinishedBlob(builder) : nullptr;
provider_ = new MockFileStreamReaderProvider();
scoped_ptr<BlobReader::FileStreamReaderProvider> temp_ptr(provider_);
- reader_.reset(new BlobReader(blob_handle_.get(), temp_ptr.Pass(),
+ reader_.reset(new BlobReader(blob_handle_.get(), std::move(temp_ptr),
message_loop_.task_runner().get()));
}
@@ -729,7 +729,7 @@ TEST_F(BlobReaderTest, DiskCacheAsync) {
scoped_refptr<BlobDataBuilder::DataHandle> data_handle =
new EmptyDataHandle();
scoped_ptr<DelayedReadEntry> delayed_read_entry(new DelayedReadEntry(
- CreateDiskCacheEntry(cache.get(), "test entry", kData).Pass()));
+ CreateDiskCacheEntry(cache.get(), "test entry", kData)));
b.AppendDiskCacheEntry(data_handle, delayed_read_entry.get(),
kTestDiskCacheStreamIndex);
this->InitializeReader(&b);
diff --git a/content/browser/fileapi/blob_storage_context_unittest.cc b/content/browser/fileapi/blob_storage_context_unittest.cc
index a2216ca..72df984 100644
--- a/content/browser/fileapi/blob_storage_context_unittest.cc
+++ b/content/browser/fileapi/blob_storage_context_unittest.cc
@@ -54,7 +54,7 @@ scoped_ptr<disk_cache::Backend> CreateInMemoryDiskCache() {
callback.callback());
EXPECT_EQ(net::OK, callback.GetResult(rv));
- return cache.Pass();
+ return cache;
}
disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
@@ -71,7 +71,7 @@ disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
rv = entry->WriteData(kTestDiskCacheStreamIndex, 0, iobuffer.get(),
iobuffer->size(), callback.callback(), false);
EXPECT_EQ(static_cast<int>(data.size()), callback.GetResult(rv));
- return entry.Pass();
+ return entry;
}
void SetupBasicBlob(BlobStorageHost* host, const std::string& id) {
diff --git a/content/browser/fileapi/blob_url_request_job_unittest.cc b/content/browser/fileapi/blob_url_request_job_unittest.cc
index 5edc79a..782a1e5 100644
--- a/content/browser/fileapi/blob_url_request_job_unittest.cc
+++ b/content/browser/fileapi/blob_url_request_job_unittest.cc
@@ -83,7 +83,7 @@ scoped_ptr<disk_cache::Backend> CreateInMemoryDiskCache() {
callback.callback());
EXPECT_EQ(net::OK, callback.GetResult(rv));
- return cache.Pass();
+ return cache;
}
disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
@@ -100,7 +100,7 @@ disk_cache::ScopedEntryPtr CreateDiskCacheEntry(disk_cache::Backend* cache,
rv = entry->WriteData(kTestDiskCacheStreamIndex, 0, iobuffer.get(),
iobuffer->size(), callback.callback(), false);
EXPECT_EQ(static_cast<int>(data.size()), callback.GetResult(rv));
- return entry.Pass();
+ return entry;
}
} // namespace
@@ -288,7 +288,7 @@ class BlobURLRequestJobTest : public testing::Test {
storage::BlobDataHandle* GetHandleFromBuilder() {
if (!blob_handle_) {
- blob_handle_ = blob_context_.AddFinishedBlob(blob_data_.get()).Pass();
+ blob_handle_ = blob_context_.AddFinishedBlob(blob_data_.get());
}
return blob_handle_.get();
}
diff --git a/content/browser/fileapi/browser_file_system_helper.cc b/content/browser/fileapi/browser_file_system_helper.cc
index ee8ffb2..64402cd 100644
--- a/content/browser/fileapi/browser_file_system_helper.cc
+++ b/content/browser/fileapi/browser_file_system_helper.cc
@@ -5,8 +5,8 @@
#include "content/browser/fileapi/browser_file_system_helper.h"
#include <stddef.h>
-
#include <string>
+#include <utility>
#include <vector>
#include "base/command_line.h"
@@ -79,12 +79,9 @@ scoped_refptr<storage::FileSystemContext> CreateFileSystemContext(
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO).get(),
file_task_runner.get(),
BrowserContext::GetMountPoints(browser_context),
- browser_context->GetSpecialStoragePolicy(),
- quota_manager_proxy,
- additional_backends.Pass(),
- url_request_auto_mount_handlers,
- profile_path,
- CreateBrowserFileSystemOptions(is_incognito));
+ browser_context->GetSpecialStoragePolicy(), quota_manager_proxy,
+ std::move(additional_backends), url_request_auto_mount_handlers,
+ profile_path, CreateBrowserFileSystemOptions(is_incognito));
std::vector<storage::FileSystemType> types;
file_system_context->GetFileSystemTypes(&types);
diff --git a/content/browser/fileapi/chrome_blob_storage_context.cc b/content/browser/fileapi/chrome_blob_storage_context.cc
index 5e2c4c8..8b9ed71 100644
--- a/content/browser/fileapi/chrome_blob_storage_context.cc
+++ b/content/browser/fileapi/chrome_blob_storage_context.cc
@@ -4,6 +4,8 @@
#include "content/browser/fileapi/chrome_blob_storage_context.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/guid.h"
#include "content/public/browser/blob_handle.h"
@@ -25,7 +27,7 @@ const char kBlobStorageContextKeyName[] = "content_blob_storage_context";
class BlobHandleImpl : public BlobHandle {
public:
explicit BlobHandleImpl(scoped_ptr<storage::BlobDataHandle> handle)
- : handle_(handle.Pass()) {}
+ : handle_(std::move(handle)) {}
~BlobHandleImpl() override {}
@@ -78,8 +80,8 @@ scoped_ptr<BlobHandle> ChromeBlobStorageContext::CreateMemoryBackedBlob(
return scoped_ptr<BlobHandle>();
scoped_ptr<BlobHandle> blob_handle(
- new BlobHandleImpl(blob_data_handle.Pass()));
- return blob_handle.Pass();
+ new BlobHandleImpl(std::move(blob_data_handle)));
+ return blob_handle;
}
scoped_ptr<BlobHandle> ChromeBlobStorageContext::CreateFileBackedBlob(
@@ -99,8 +101,8 @@ scoped_ptr<BlobHandle> ChromeBlobStorageContext::CreateFileBackedBlob(
return scoped_ptr<BlobHandle>();
scoped_ptr<BlobHandle> blob_handle(
- new BlobHandleImpl(blob_data_handle.Pass()));
- return blob_handle.Pass();
+ new BlobHandleImpl(std::move(blob_data_handle)));
+ return blob_handle;
}
ChromeBlobStorageContext::~ChromeBlobStorageContext() {}
diff --git a/content/browser/fileapi/copy_or_move_file_validator_unittest.cc b/content/browser/fileapi/copy_or_move_file_validator_unittest.cc
index c099f29..2b62b53 100644
--- a/content/browser/fileapi/copy_or_move_file_validator_unittest.cc
+++ b/content/browser/fileapi/copy_or_move_file_validator_unittest.cc
@@ -4,6 +4,7 @@
#include <stddef.h>
#include <stdint.h>
+#include <utility>
#include "base/bind.h"
#include "base/files/file_path.h"
@@ -102,7 +103,7 @@ class CopyOrMoveFileValidatorTestHelper {
scoped_ptr<storage::CopyOrMoveFileValidatorFactory> factory) {
TestFileSystemBackend* backend = static_cast<TestFileSystemBackend*>(
file_system_context_->GetFileSystemBackend(kWithValidatorType));
- backend->InitializeCopyOrMoveFileValidatorFactory(factory.Pass());
+ backend->InitializeCopyOrMoveFileValidatorFactory(std::move(factory));
}
void CopyTest(base::File::Error expected) {
@@ -282,7 +283,7 @@ TEST(CopyOrMoveFileValidatorTest, AcceptAll) {
helper.SetUp();
scoped_ptr<CopyOrMoveFileValidatorFactory> factory(
new TestCopyOrMoveFileValidatorFactory(VALID));
- helper.SetMediaCopyOrMoveFileValidatorFactory(factory.Pass());
+ helper.SetMediaCopyOrMoveFileValidatorFactory(std::move(factory));
helper.CopyTest(base::File::FILE_OK);
helper.MoveTest(base::File::FILE_OK);
@@ -295,7 +296,7 @@ TEST(CopyOrMoveFileValidatorTest, AcceptNone) {
helper.SetUp();
scoped_ptr<CopyOrMoveFileValidatorFactory> factory(
new TestCopyOrMoveFileValidatorFactory(PRE_WRITE_INVALID));
- helper.SetMediaCopyOrMoveFileValidatorFactory(factory.Pass());
+ helper.SetMediaCopyOrMoveFileValidatorFactory(std::move(factory));
helper.CopyTest(base::File::FILE_ERROR_SECURITY);
helper.MoveTest(base::File::FILE_ERROR_SECURITY);
@@ -309,11 +310,11 @@ TEST(CopyOrMoveFileValidatorTest, OverrideValidator) {
helper.SetUp();
scoped_ptr<CopyOrMoveFileValidatorFactory> reject_factory(
new TestCopyOrMoveFileValidatorFactory(PRE_WRITE_INVALID));
- helper.SetMediaCopyOrMoveFileValidatorFactory(reject_factory.Pass());
+ helper.SetMediaCopyOrMoveFileValidatorFactory(std::move(reject_factory));
scoped_ptr<CopyOrMoveFileValidatorFactory> accept_factory(
new TestCopyOrMoveFileValidatorFactory(VALID));
- helper.SetMediaCopyOrMoveFileValidatorFactory(accept_factory.Pass());
+ helper.SetMediaCopyOrMoveFileValidatorFactory(std::move(accept_factory));
helper.CopyTest(base::File::FILE_ERROR_SECURITY);
helper.MoveTest(base::File::FILE_ERROR_SECURITY);
@@ -326,7 +327,7 @@ TEST(CopyOrMoveFileValidatorTest, RejectPostWrite) {
helper.SetUp();
scoped_ptr<CopyOrMoveFileValidatorFactory> factory(
new TestCopyOrMoveFileValidatorFactory(POST_WRITE_INVALID));
- helper.SetMediaCopyOrMoveFileValidatorFactory(factory.Pass());
+ helper.SetMediaCopyOrMoveFileValidatorFactory(std::move(factory));
helper.CopyTest(base::File::FILE_ERROR_SECURITY);
helper.MoveTest(base::File::FILE_ERROR_SECURITY);
diff --git a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
index 85f3c7e..055b8f2 100644
--- a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
+++ b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
@@ -4,9 +4,9 @@
#include <stddef.h>
#include <stdint.h>
-
#include <map>
#include <queue>
+#include <utility>
#include "base/bind.h"
#include "base/files/file_util.h"
@@ -221,7 +221,8 @@ class CopyOrMoveOperationTestHelper {
test_backend->set_require_copy_or_move_validator(
require_copy_or_move_validator);
if (init_copy_or_move_validator)
- test_backend->InitializeCopyOrMoveFileValidatorFactory(factory.Pass());
+ test_backend->InitializeCopyOrMoveFileValidatorFactory(
+ std::move(factory));
}
backend->ResolveURL(
FileSystemURL::CreateForTest(origin_, dest_type_, base::FilePath()),
@@ -744,7 +745,7 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper) {
std::vector<int64_t> progress;
CopyOrMoveOperationDelegate::StreamCopyHelper helper(
- reader.Pass(), writer.Pass(),
+ std::move(reader), std::move(writer),
storage::FlushPolicy::NO_FLUSH_ON_COMPLETION,
10, // buffer size
base::Bind(&RecordFileProgressCallback, base::Unretained(&progress)),
@@ -800,7 +801,7 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelperWithFlush) {
std::vector<int64_t> progress;
CopyOrMoveOperationDelegate::StreamCopyHelper helper(
- reader.Pass(), writer.Pass(),
+ std::move(reader), std::move(writer),
storage::FlushPolicy::NO_FLUSH_ON_COMPLETION,
10, // buffer size
base::Bind(&RecordFileProgressCallback, base::Unretained(&progress)),
@@ -851,7 +852,7 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper_Cancel) {
std::vector<int64_t> progress;
CopyOrMoveOperationDelegate::StreamCopyHelper helper(
- reader.Pass(), writer.Pass(),
+ std::move(reader), std::move(writer),
storage::FlushPolicy::NO_FLUSH_ON_COMPLETION,
10, // buffer size
base::Bind(&RecordFileProgressCallback, base::Unretained(&progress)),
diff --git a/content/browser/fileapi/dragged_file_util_unittest.cc b/content/browser/fileapi/dragged_file_util_unittest.cc
index 3ef9f8c..07c983b 100644
--- a/content/browser/fileapi/dragged_file_util_unittest.cc
+++ b/content/browser/fileapi/dragged_file_util_unittest.cc
@@ -251,8 +251,8 @@ class DraggedFileUtilTest : public testing::Test {
}
scoped_ptr<storage::FileSystemOperationContext> GetOperationContext() {
- return make_scoped_ptr(new storage::FileSystemOperationContext(
- file_system_context())).Pass();
+ return make_scoped_ptr(
+ new storage::FileSystemOperationContext(file_system_context()));
}
diff --git a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
index 1cce5e7..15f376c 100644
--- a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
+++ b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
@@ -2,11 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "storage/browser/fileapi/file_system_dir_url_request_job.h"
-
#include <stdint.h>
-
#include <string>
+#include <utility>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
@@ -32,6 +30,7 @@
#include "net/url_request/url_request_test_util.h"
#include "storage/browser/fileapi/external_mount_points.h"
#include "storage/browser/fileapi/file_system_context.h"
+#include "storage/browser/fileapi/file_system_dir_url_request_job.h"
#include "storage/browser/fileapi/file_system_file_util.h"
#include "storage/browser/fileapi/file_system_operation_context.h"
#include "storage/browser/fileapi/file_system_url.h"
@@ -164,7 +163,7 @@ class FileSystemDirURLRequestJobTest : public testing::Test {
handlers.push_back(base::Bind(&TestAutoMountForURLRequest));
file_system_context_ = CreateFileSystemContextWithAutoMountersForTesting(
- NULL, additional_providers.Pass(), handlers, temp_dir_.path());
+ NULL, std::move(additional_providers), handlers, temp_dir_.path());
}
void OnOpenFileSystem(const GURL& root_url,
diff --git a/content/browser/fileapi/file_system_operation_impl_write_unittest.cc b/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
index b6e07e8..34ed554 100644
--- a/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
+++ b/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include <stdint.h>
-
+#include <utility>
#include <vector>
#include "base/files/scoped_temp_dir.h"
@@ -212,8 +212,8 @@ TEST_F(FileSystemOperationImplWriteTest, TestWriteZero) {
TEST_F(FileSystemOperationImplWriteTest, TestWriteInvalidBlobUrl) {
scoped_ptr<storage::BlobDataHandle> null_handle;
file_system_context_->operation_runner()->Write(
- &url_request_context(), URLForPath(virtual_path_),
- null_handle.Pass(), 0, RecordWriteCallback());
+ &url_request_context(), URLForPath(virtual_path_), std::move(null_handle),
+ 0, RecordWriteCallback());
base::MessageLoop::current()->Run();
EXPECT_EQ(0, bytes_written());
diff --git a/content/browser/fileapi/file_system_operation_runner_unittest.cc b/content/browser/fileapi/file_system_operation_runner_unittest.cc
index 6701805..082a7e3d 100644
--- a/content/browser/fileapi/file_system_operation_runner_unittest.cc
+++ b/content/browser/fileapi/file_system_operation_runner_unittest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <utility>
+
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
@@ -194,11 +196,9 @@ class MultiThreadFileSystemOperationRunnerTest : public testing::Test {
base::ThreadTaskRunnerHandle::Get().get(),
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get(),
storage::ExternalMountPoints::CreateRefCounted().get(),
- make_scoped_refptr(new MockSpecialStoragePolicy()).get(),
- nullptr,
- additional_providers.Pass(),
- std::vector<storage::URLRequestAutoMountHandler>(),
- base_dir,
+ make_scoped_refptr(new MockSpecialStoragePolicy()).get(), nullptr,
+ std::move(additional_providers),
+ std::vector<storage::URLRequestAutoMountHandler>(), base_dir,
CreateAllowFileAccessOptions());
// Disallow IO on the main loop.
diff --git a/content/browser/fileapi/file_system_url_request_job_unittest.cc b/content/browser/fileapi/file_system_url_request_job_unittest.cc
index f9b72ed..4b2715c 100644
--- a/content/browser/fileapi/file_system_url_request_job_unittest.cc
+++ b/content/browser/fileapi/file_system_url_request_job_unittest.cc
@@ -2,11 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "storage/browser/fileapi/file_system_url_request_job.h"
-
#include <stddef.h>
-
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/files/file_path.h"
@@ -39,6 +37,7 @@
#include "storage/browser/fileapi/external_mount_points.h"
#include "storage/browser/fileapi/file_system_context.h"
#include "storage/browser/fileapi/file_system_file_util.h"
+#include "storage/browser/fileapi/file_system_url_request_job.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::AsyncFileTestHelper;
@@ -169,7 +168,7 @@ class FileSystemURLRequestJobTest : public testing::Test {
handlers.push_back(base::Bind(&TestAutoMountForURLRequest));
file_system_context_ = CreateFileSystemContextWithAutoMountersForTesting(
- NULL, additional_providers.Pass(), handlers, temp_dir_.path());
+ NULL, std::move(additional_providers), handlers, temp_dir_.path());
ASSERT_EQ(static_cast<int>(sizeof(kTestFileData)) - 1,
base::WriteFile(mnt_point.AppendASCII("foo"), kTestFileData,
diff --git a/content/browser/fileapi/file_writer_delegate_unittest.cc b/content/browser/fileapi/file_writer_delegate_unittest.cc
index ad3cc76..c12e3c3 100644
--- a/content/browser/fileapi/file_writer_delegate_unittest.cc
+++ b/content/browser/fileapi/file_writer_delegate_unittest.cc
@@ -3,9 +3,9 @@
// found in the LICENSE file.
#include <stdint.h>
-
#include <limits>
#include <string>
+#include <utility>
#include <vector>
#include "base/bind.h"
@@ -284,7 +284,7 @@ TEST_F(FileWriterDelegateTest, WriteSuccessWithoutQuotaLimit) {
Result result;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
@@ -304,7 +304,7 @@ TEST_F(FileWriterDelegateTest, WriteSuccessWithJustQuota) {
Result result;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
file_writer_delegate_.reset();
@@ -324,7 +324,7 @@ TEST_F(FileWriterDelegateTest, DISABLED_WriteFailureByQuota) {
Result result;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::ERROR_WRITE_STARTED, result.write_status());
file_writer_delegate_.reset();
@@ -345,7 +345,7 @@ TEST_F(FileWriterDelegateTest, WriteZeroBytesSuccessfullyWithZeroQuota) {
Result result;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
file_writer_delegate_.reset();
@@ -380,8 +380,8 @@ TEST_F(FileWriterDelegateTest, WriteSuccessWithoutQuotaLimitConcurrent) {
Result result, result2;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
- file_writer_delegate2->Start(request2.Pass(), GetWriteCallback(&result2));
+ file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
+ file_writer_delegate2->Start(std::move(request2), GetWriteCallback(&result2));
base::MessageLoop::current()->Run();
if (result.write_status() == FileWriterDelegate::SUCCESS_IO_PENDING ||
result2.write_status() == FileWriterDelegate::SUCCESS_IO_PENDING)
@@ -414,7 +414,8 @@ TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
{
Result result;
ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_),
+ GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
file_writer_delegate_.reset();
@@ -432,7 +433,8 @@ TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
{
Result result;
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_),
+ GetWriteCallback(&result));
base::MessageLoop::current()->Run();
EXPECT_EQ(kDataSize, usage());
EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
@@ -449,7 +451,8 @@ TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
{
Result result;
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_),
+ GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
file_writer_delegate_.reset();
@@ -468,7 +471,8 @@ TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
{
Result result;
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_),
+ GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
file_writer_delegate_.reset();
@@ -488,7 +492,8 @@ TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
{
Result result;
- file_writer_delegate_->Start(request_.Pass(), GetWriteCallback(&result));
+ file_writer_delegate_->Start(std::move(request_),
+ GetWriteCallback(&result));
base::MessageLoop::current()->Run();
ASSERT_EQ(FileWriterDelegate::ERROR_WRITE_STARTED, result.write_status());
file_writer_delegate_.reset();
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index 6ce1d4a..8594aef 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -5,6 +5,7 @@
#include "content/browser/fileapi/fileapi_message_filter.h"
#include <string>
+#include <utility>
#include <vector>
#include "base/bind.h"
@@ -411,7 +412,7 @@ void FileAPIMessageFilter::OnWrite(int request_id,
blob_storage_context_->context()->GetBlobDataFromUUID(blob_uuid);
operations_[request_id] = operation_runner()->Write(
- request_context_, url, blob.Pass(), offset,
+ request_context_, url, std::move(blob), offset,
base::Bind(&FileAPIMessageFilter::DidWrite, this, request_id));
}
diff --git a/content/browser/fileapi/obfuscated_file_util_unittest.cc b/content/browser/fileapi/obfuscated_file_util_unittest.cc
index cda3c92..8d434fa 100644
--- a/content/browser/fileapi/obfuscated_file_util_unittest.cc
+++ b/content/browser/fileapi/obfuscated_file_util_unittest.cc
@@ -4,10 +4,10 @@
#include <stddef.h>
#include <stdint.h>
-
#include <limits>
#include <set>
#include <string>
+#include <utility>
#include <vector>
#include "base/bind.h"
@@ -192,7 +192,7 @@ class ObfuscatedFileUtilTest : public testing::Test {
scoped_ptr<FileSystemOperationContext> context(
sandbox_file_system_.NewOperationContext());
context->set_allowed_bytes_growth(allowed_bytes_growth);
- return context.Pass();
+ return context;
}
scoped_ptr<FileSystemOperationContext> UnlimitedContext() {
@@ -400,7 +400,7 @@ class ObfuscatedFileUtilTest : public testing::Test {
UsageVerifyHelper(scoped_ptr<FileSystemOperationContext> context,
SandboxFileSystemTestHelper* file_system,
int64_t expected_usage)
- : context_(context.Pass()),
+ : context_(std::move(context)),
sandbox_file_system_(file_system),
expected_usage_(expected_usage) {}
@@ -851,7 +851,7 @@ TEST_F(ObfuscatedFileUtilTest, TestCreateAndDeleteFile) {
ASSERT_TRUE(file.created());
EXPECT_EQ(1, change_observer()->get_and_reset_create_file_count());
- CheckFileAndCloseHandle(url, file.Pass());
+ CheckFileAndCloseHandle(url, std::move(file));
context.reset(NewContext(NULL));
base::FilePath local_path;
@@ -887,7 +887,7 @@ TEST_F(ObfuscatedFileUtilTest, TestCreateAndDeleteFile) {
ASSERT_TRUE(file.created());
EXPECT_EQ(1, change_observer()->get_and_reset_create_file_count());
- CheckFileAndCloseHandle(url, file.Pass());
+ CheckFileAndCloseHandle(url, std::move(file));
context.reset(NewContext(NULL));
EXPECT_EQ(base::File::FILE_OK,