diff options
| author | zmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 20:05:00 +0000 |
|---|---|---|
| committer | zmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 20:05:00 +0000 |
| commit | d7b5cc74aad6ae9f5f8425a9dba0c6f3b7a4e058 (patch) | |
| tree | 80ed4f402a2df66036b1c46a80ff29d77dd2fa64 /content/browser/gpu/gpu_data_manager_impl.h | |
| parent | 863b582d75c8f9acf404751d7e709803df1f7bb9 (diff) | |
| download | chromium_src-d7b5cc74aad6ae9f5f8425a9dba0c6f3b7a4e058.zip chromium_src-d7b5cc74aad6ae9f5f8425a9dba0c6f3b7a4e058.tar.gz chromium_src-d7b5cc74aad6ae9f5f8425a9dba0c6f3b7a4e058.tar.bz2 | |
Move GPU device/driver info related code from content to gpu.
Try to reland r201380 with build fix.
This has been suggested by gman, and agreed by kbr and jam, for the following reasons:
1) These are gpu related code, and are independent of content / browser, so putting them under gpu/ is the right thing to do conceptually.
2) This enables us to set up tests in various places with the correct blacklisting/driver_bug_workarounds information. Otherwise, for the moment, gpu/ has no visibility into content/ side, so we have to duplicate the driver_bug_workarounds code and hardwire them for testing purpose. This is going to cause a lot of bugs in the future, as we have the two pieces of code for the same thing (one for chrome and one for testing) and people will easily forget to update one or the other.
As for this patch, I didn't change the logic, and try to minimize the refactoring. All improvements enabled by this relocation will be done in follow-up CLs.
BUG=230477
TEST=tree
TBR=apatrick@chromium.org, joi@chromium.org, kbr@chromium.org, piman@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/15745014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201875 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/gpu/gpu_data_manager_impl.h')
| -rw-r--r-- | content/browser/gpu/gpu_data_manager_impl.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/content/browser/gpu/gpu_data_manager_impl.h b/content/browser/gpu/gpu_data_manager_impl.h index 32ff23b..2e6567a 100644 --- a/content/browser/gpu/gpu_data_manager_impl.h +++ b/content/browser/gpu/gpu_data_manager_impl.h @@ -18,10 +18,10 @@ #include "base/time.h" #include "base/values.h" #include "content/public/browser/gpu_data_manager.h" -#include "content/public/common/gpu_info.h" #include "content/public/common/gpu_memory_stats.h" -#include "content/public/common/gpu_switching_option.h" #include "content/public/common/three_d_api_types.h" +#include "gpu/config/gpu_info.h" +#include "gpu/config/gpu_switching_option.h" class CommandLine; class GURL; @@ -58,9 +58,9 @@ class CONTENT_EXPORT GpuDataManagerImpl // GpuDataManager implementation. virtual void InitializeForTesting( const std::string& gpu_blacklist_json, - const GPUInfo& gpu_info) OVERRIDE; + const gpu::GPUInfo& gpu_info) OVERRIDE; virtual bool IsFeatureBlacklisted(int feature) const OVERRIDE; - virtual GPUInfo GetGPUInfo() const OVERRIDE; + virtual gpu::GPUInfo GetGPUInfo() const OVERRIDE; virtual void GetGpuProcessHandles( const GetGpuProcessHandlesCallback& callback) const OVERRIDE; virtual bool GpuAccessAllowed(std::string* reason) const OVERRIDE; @@ -88,7 +88,7 @@ class CONTENT_EXPORT GpuDataManagerImpl // Only update if the current GPUInfo is not finalized. If blacklist is // loaded, run through blacklist and update blacklisted features. - void UpdateGpuInfo(const GPUInfo& gpu_info); + void UpdateGpuInfo(const gpu::GPUInfo& gpu_info); void UpdateVideoMemoryUsageStats( const GPUVideoMemoryUsageStats& video_memory_usage_stats); @@ -108,7 +108,7 @@ class CONTENT_EXPORT GpuDataManagerImpl // Update WebPreferences for renderer based on blacklisting decisions. void UpdateRendererWebPrefs(WebPreferences* prefs) const; - GpuSwitchingOption GetGpuSwitchingOption() const; + gpu::GpuSwitchingOption GetGpuSwitchingOption() const; std::string GetBlacklistVersion() const; |