summaryrefslogtreecommitdiffstats
path: root/content/browser/hyphenator
diff options
context:
space:
mode:
authortommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-28 14:26:10 +0000
committertommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-28 14:26:10 +0000
commit795ebc3fcb515495bd5dea7c6e1fcc101b78aabc (patch)
tree0bfd64236ce994ecf364b3952bc19c875f52332c /content/browser/hyphenator
parent1fe90e53a57062017b3e7f1c358a91b72190376c (diff)
downloadchromium_src-795ebc3fcb515495bd5dea7c6e1fcc101b78aabc.zip
chromium_src-795ebc3fcb515495bd5dea7c6e1fcc101b78aabc.tar.gz
chromium_src-795ebc3fcb515495bd5dea7c6e1fcc101b78aabc.tar.bz2
Fix bug in HyphenatorMessageFilterTest.OpenDictionary where a file descriptor was being closed twice.
This caused this exception to be thrown while debugging content_unittests: 'Unhandled exception at 0x76E812F7 in content_unittests.exe: 0xC0000008: An invalid handle was specified' BUG=none TEST=Fixes content_unittests --gtest_filter=HyphenatorMessageFilterTest.OpenDictionary TBR=hbono@chromium.org Review URL: https://codereview.chromium.org/11299227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169931 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/hyphenator')
-rw-r--r--content/browser/hyphenator/hyphenator_message_filter_unittest.cc3
1 files changed, 1 insertions, 2 deletions
diff --git a/content/browser/hyphenator/hyphenator_message_filter_unittest.cc b/content/browser/hyphenator/hyphenator_message_filter_unittest.cc
index 2c047b8..469f194 100644
--- a/content/browser/hyphenator/hyphenator_message_filter_unittest.cc
+++ b/content/browser/hyphenator/hyphenator_message_filter_unittest.cc
@@ -131,6 +131,7 @@ TEST_F(HyphenatorMessageFilterTest, OpenDictionary) {
NULL, NULL);
EXPECT_NE(base::kInvalidPlatformFileValue, file);
filter_->SetDictionary(file);
+ file = base::kInvalidPlatformFileValue; // Ownership has been transferred.
// Send a HyphenatorHostMsg_OpenDictionary message with an empty locale and
// verify it sends a HyphenatorMsg_SetDictionary message with a valid file.
@@ -148,8 +149,6 @@ TEST_F(HyphenatorMessageFilterTest, OpenDictionary) {
// Delete all resources used by this test.
filter_->Reset();
- if (file != base::kInvalidPlatformFileValue)
- base::ClosePlatformFile(file);
}
} // namespace content