diff options
| author | Mitsuru Oshima <oshima@chromium.org> | 2014-10-24 10:45:30 -0700 |
|---|---|---|
| committer | Mitsuru Oshima <oshima@chromium.org> | 2014-10-24 17:46:18 +0000 |
| commit | db286f1acb2466ee4af059c463a86bb66269d7e8 (patch) | |
| tree | aa64c8eb87922b05ad9d0e567b5133f67c2ea529 /content/browser/loader/resource_request_info_impl.h | |
| parent | 88c22039e02d0776a19e949bf8119ba9957d4cd0 (diff) | |
| download | chromium_src-db286f1acb2466ee4af059c463a86bb66269d7e8.zip chromium_src-db286f1acb2466ee4af059c463a86bb66269d7e8.tar.gz chromium_src-db286f1acb2466ee4af059c463a86bb66269d7e8.tar.bz2 | |
Revert "Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS."
> Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS.
> It's only used by Loader code.
> BUG=426442
>
> Review URL: https://codereview.chromium.org/669073003
>
> Cr-Commit-Position: refs/heads/master@{#301110}
TBR=ljagielski@opera.com
Reason for revert:
This is causing use-of-unititialized-value on msan bots.
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Browser%20%281%29/builds/1746/steps/browser_tests/logs/stdio
==29276== WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fcb9a0f0d17 in content::ResourceLoader::ReportUploadProgress() content/browser/loader/resource_loader.cc:163:9
#1 0x7fcb9a0f3241 in content::ResourceLoader::OnResponseStarted(net::URLRequest*) content/browser/loader/resource_loader.cc:341:3
#2 0x7fcb980bb80f in net::URLRequestJob::NotifyHeadersComplete() net/url_request/url_request_job.cc:376:3
#3 0x7fcb98304f13 in net::URLRequestHttpJob::NotifyHeadersComplete() net/url_request/url_request_http_job.cc:355:3
#4 0x7fcb983080de in net::URLRequestHttpJob::SaveNextCookie() net/url_request/url_request_http_job.cc:692:5
#5 0x7fcb98301b30 in net::URLRequestHttpJob::OnStartCompleted(int) net/url_request/url_request_http_job.cc:848:5
#6 0x7fcb97f1f140 in Run base/callback.h:441:12
#7 0x7fcb97f1f140 in net::HttpCache::Transaction::DoCallback(int) net/http/http_cache_transaction.cc:727:0
#8 0x7fcb97f1ae2f in HandleResult net/http/http_cache_transaction.cc:733:5
#9 0x7fcb97f1ae2f in net::HttpCache::Transaction::DoLoop(int) net/http/http_cache_transaction.cc:994:0
#10 0x7fcb97f185f4 in net::HttpCache::Transaction::OnIOComplete(int) net/http/http_cache_transaction.cc:2955:3
Review URL: https://codereview.chromium.org/680583002
Cr-Commit-Position: refs/heads/master@{#301139}
Diffstat (limited to 'content/browser/loader/resource_request_info_impl.h')
| -rw-r--r-- | content/browser/loader/resource_request_info_impl.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/content/browser/loader/resource_request_info_impl.h b/content/browser/loader/resource_request_info_impl.h index 6b75fcd..696eaa2 100644 --- a/content/browser/loader/resource_request_info_impl.h +++ b/content/browser/loader/resource_request_info_impl.h @@ -57,7 +57,6 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo, bool allow_download, bool has_user_gesture, bool enable_load_timing, - bool enable_upload_progress, blink::WebReferrerPolicy referrer_policy, blink::WebPageVisibilityState visibility_state, ResourceContext* context, @@ -165,8 +164,6 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo, bool is_load_timing_enabled() const { return enable_load_timing_; } - bool is_upload_progress_enabled() const { return enable_upload_progress_; } - private: FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest, DeletedFilterDetached); @@ -191,7 +188,6 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo, bool allow_download_; bool has_user_gesture_; bool enable_load_timing_; - bool enable_upload_progress_; bool was_ignored_by_handler_; bool counted_as_in_flight_request_; ResourceType resource_type_; |