diff options
| author | creis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-15 19:38:18 +0000 |
|---|---|---|
| committer | creis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-15 19:38:18 +0000 |
| commit | ef5306ef2dc2460f0a0af8498f80d712ab3ec0b6 (patch) | |
| tree | 329dce616f82e857d3c323822d446e1ef6e657ce /content/browser/loader/sync_resource_handler.h | |
| parent | 0de673b86444c59ad7e45021a4cbc911afdaeffc (diff) | |
| download | chromium_src-ef5306ef2dc2460f0a0af8498f80d712ab3ec0b6.zip chromium_src-ef5306ef2dc2460f0a0af8498f80d712ab3ec0b6.tar.gz chromium_src-ef5306ef2dc2460f0a0af8498f80d712ab3ec0b6.tar.bz2 | |
Clean up ResourceHandler API.
1. Move URLRequest member to ResourceHandler base class and add convenience functions for subclasses.
2. Make OnWillRead take a scoped_refptr to avoid leaking the buffer.
(Attempt 2, after being reverted for possibly unrelated crashes.)
BUG=295239
TEST=No behavior change.
TBR=darin
Review URL: https://codereview.chromium.org/26420005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228741 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/loader/sync_resource_handler.h')
| -rw-r--r-- | content/browser/loader/sync_resource_handler.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/content/browser/loader/sync_resource_handler.h b/content/browser/loader/sync_resource_handler.h index 358d92a..41c51f2 100644 --- a/content/browser/loader/sync_resource_handler.h +++ b/content/browser/loader/sync_resource_handler.h @@ -47,7 +47,7 @@ class SyncResourceHandler : public ResourceHandler { const GURL& url, bool* defer) OVERRIDE; virtual bool OnWillRead(int request_id, - net::IOBuffer** buf, + scoped_refptr<net::IOBuffer>* buf, int* buf_size, int min_size) OVERRIDE; virtual bool OnReadCompleted(int request_id, @@ -64,7 +64,6 @@ class SyncResourceHandler : public ResourceHandler { scoped_refptr<net::IOBuffer> read_buffer_; SyncLoadResult result_; - net::URLRequest* request_; IPC::Message* result_message_; ResourceDispatcherHostImpl* rdh_; }; |