diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 23:17:16 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 23:17:16 +0000 |
commit | f3add92d73df86fa62bf727b0016e0c62149b326 (patch) | |
tree | f2d0012dd68061378276814f1c5108e010bda7a5 /content/browser/loader | |
parent | 13c3497e0bf749e2bf9bb4e0112bf7b1bab63933 (diff) | |
download | chromium_src-f3add92d73df86fa62bf727b0016e0c62149b326.zip chromium_src-f3add92d73df86fa62bf727b0016e0c62149b326.tar.gz chromium_src-f3add92d73df86fa62bf727b0016e0c62149b326.tar.bz2 |
A bunch of work to transition from render_view_id to render_frame_id.
-remove ResourceRequestInfo::GetRenderViewForRequest
-reduce usage of GetAssociatedRenderView and add GetAssociatedRenderFrame which will replace it
-move the cookie jar from RenderView to RenderFrame
-switch most of the usages of RenderView to RenderFrame in WebPluginImpl
BUG=304341
R=boliu@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/114573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242200 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/loader')
-rw-r--r-- | content/browser/loader/resource_request_info_impl.cc | 40 | ||||
-rw-r--r-- | content/browser/loader/resource_request_info_impl.h | 2 |
2 files changed, 35 insertions, 7 deletions
diff --git a/content/browser/loader/resource_request_info_impl.cc b/content/browser/loader/resource_request_info_impl.cc index 32ba7ac..c1ccc91 100644 --- a/content/browser/loader/resource_request_info_impl.cc +++ b/content/browser/loader/resource_request_info_impl.cc @@ -57,16 +57,16 @@ void ResourceRequestInfo::AllocateForTesting( } // static -bool ResourceRequestInfo::GetRenderViewForRequest( +bool ResourceRequestInfo::GetRenderFrameForRequest( const net::URLRequest* request, int* render_process_id, - int* render_view_id) { + int* render_frame_id) { URLRequestUserData* user_data = static_cast<URLRequestUserData*>( request->GetUserData(URLRequestUserData::kUserDataKey)); if (!user_data) return false; *render_process_id = user_data->render_process_id(); - *render_view_id = user_data->render_view_id(); + *render_frame_id = user_data->render_frame_id(); return true; } @@ -205,8 +205,9 @@ bool ResourceRequestInfoImpl::GetAssociatedRenderView( if (process_type_ == PROCESS_TYPE_WORKER) { // Need to display some related UI for this network request - pick an // arbitrary parent to do so. + int unused; if (!WorkerServiceImpl::GetInstance()->GetRendererForWorker( - child_id_, render_process_id, render_view_id)) { + child_id_, render_process_id, render_view_id, &unused)) { *render_process_id = -1; *render_view_id = -1; return false; @@ -221,6 +222,31 @@ bool ResourceRequestInfoImpl::GetAssociatedRenderView( return true; } +bool ResourceRequestInfoImpl::GetAssociatedRenderFrame( + int* render_process_id, + int* render_frame_id) const { + // If the request is from the worker process, find a content that owns the + // worker. + if (process_type_ == PROCESS_TYPE_WORKER) { + // Need to display some related UI for this network request - pick an + // arbitrary parent to do so. + int unused; + if (!WorkerServiceImpl::GetInstance()->GetRendererForWorker( + child_id_, render_process_id, &unused, render_frame_id)) { + *render_process_id = -1; + *render_frame_id = -1; + return false; + } + } else if (process_type_ == PROCESS_TYPE_PLUGIN) { + *render_process_id = origin_pid_; + *render_frame_id = render_frame_id_; + } else { + *render_process_id = child_id_; + *render_frame_id = render_frame_id_; + } + return true; +} + bool ResourceRequestInfoImpl::IsAsync() const { return is_async_; } @@ -232,11 +258,11 @@ bool ResourceRequestInfoImpl::IsDownload() const { void ResourceRequestInfoImpl::AssociateWithRequest(net::URLRequest* request) { request->SetUserData(NULL, this); int render_process_id; - int render_view_id; - if (GetAssociatedRenderView(&render_process_id, &render_view_id)) { + int render_frame_id; + if (GetAssociatedRenderFrame(&render_process_id, &render_frame_id)) { request->SetUserData( URLRequestUserData::kUserDataKey, - new URLRequestUserData(render_process_id, render_view_id)); + new URLRequestUserData(render_process_id, render_frame_id)); } } diff --git a/content/browser/loader/resource_request_info_impl.h b/content/browser/loader/resource_request_info_impl.h index 2635106..6327e9a 100644 --- a/content/browser/loader/resource_request_info_impl.h +++ b/content/browser/loader/resource_request_info_impl.h @@ -81,6 +81,8 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo, virtual bool WasIgnoredByHandler() const OVERRIDE; virtual bool GetAssociatedRenderView(int* render_process_id, int* render_view_id) const OVERRIDE; + virtual bool GetAssociatedRenderFrame(int* render_process_id, + int* render_frame_id) const OVERRIDE; virtual bool IsAsync() const OVERRIDE; virtual bool IsDownload() const OVERRIDE; |