diff options
author | dcheng <dcheng@chromium.org> | 2015-12-25 22:16:36 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-26 06:17:30 +0000 |
commit | 36b6aec9a5f4953e2177146503096ca7de00cc36 (patch) | |
tree | a1d68bc1fab0b8127d7f47d3f9b3550eada5ac15 /content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc | |
parent | 2729e442b1172c5094503a03fe356c8580bb919d (diff) | |
download | chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.zip chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.gz chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.bz2 |
Convert Pass()→std::move() in //content/browser
BUG=557422
Review URL: https://codereview.chromium.org/1545243002
Cr-Commit-Position: refs/heads/master@{#366894}
Diffstat (limited to 'content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc')
-rw-r--r-- | content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc | 86 |
1 files changed, 44 insertions, 42 deletions
diff --git a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc index dccbbc3..9369bfd 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc +++ b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc @@ -2,14 +2,16 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include "content/browser/renderer_host/input/synthetic_gesture_controller.h" + #include <stddef.h> #include <stdint.h> +#include <utility> #include "base/bind.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" -#include "content/browser/renderer_host/input/synthetic_gesture_controller.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" #include "content/browser/renderer_host/input/synthetic_pinch_gesture.h" #include "content/browser/renderer_host/input/synthetic_pointer_action.h" @@ -523,7 +525,7 @@ class SyntheticGestureControllerTestBase { void QueueSyntheticGesture(scoped_ptr<SyntheticGesture> gesture) { controller_->QueueSyntheticGesture( - gesture.Pass(), + std::move(gesture), base::Bind( &SyntheticGestureControllerTestBase::OnSyntheticGestureCompleted, base::Unretained(this))); @@ -600,7 +602,7 @@ TEST_F(SyntheticGestureControllerTest, SingleGesture) { bool finished = false; scoped_ptr<MockSyntheticGesture> gesture( new MockSyntheticGesture(&finished, 3)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); EXPECT_TRUE(finished); @@ -614,7 +616,7 @@ TEST_F(SyntheticGestureControllerTest, GestureFailed) { bool finished = false; scoped_ptr<MockSyntheticGesture> gesture( new MockSyntheticGesture(&finished, 0)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); EXPECT_TRUE(finished); @@ -633,7 +635,7 @@ TEST_F(SyntheticGestureControllerTest, SuccessiveGestures) { new MockSyntheticGesture(&finished_2, 4)); // Queue first gesture and wait for it to finish - QueueSyntheticGesture(gesture_1.Pass()); + QueueSyntheticGesture(std::move(gesture_1)); FlushInputUntilComplete(); EXPECT_TRUE(finished_1); @@ -641,7 +643,7 @@ TEST_F(SyntheticGestureControllerTest, SuccessiveGestures) { EXPECT_EQ(0, num_failure_); // Queue second gesture. - QueueSyntheticGesture(gesture_2.Pass()); + QueueSyntheticGesture(std::move(gesture_2)); FlushInputUntilComplete(); EXPECT_TRUE(finished_2); @@ -659,8 +661,8 @@ TEST_F(SyntheticGestureControllerTest, TwoGesturesInFlight) { scoped_ptr<MockSyntheticGesture> gesture_2( new MockSyntheticGesture(&finished_2, 4)); - QueueSyntheticGesture(gesture_1.Pass()); - QueueSyntheticGesture(gesture_2.Pass()); + QueueSyntheticGesture(std::move(gesture_1)); + QueueSyntheticGesture(std::move(gesture_2)); FlushInputUntilComplete(); EXPECT_TRUE(finished_1); @@ -679,8 +681,8 @@ TEST_F(SyntheticGestureControllerTest, GestureCompletedOnDidFlushInput) { scoped_ptr<MockSyntheticGesture> gesture_2( new MockSyntheticGesture(&finished_2, 4)); - QueueSyntheticGesture(gesture_1.Pass()); - QueueSyntheticGesture(gesture_2.Pass()); + QueueSyntheticGesture(std::move(gesture_1)); + QueueSyntheticGesture(std::move(gesture_2)); while (target_->flush_requested()) { target_->ClearFlushRequest(); @@ -734,7 +736,7 @@ TEST_P(SyntheticGestureControllerTestWithParam, scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -763,7 +765,7 @@ TEST_P(SyntheticGestureControllerTestWithParam, scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -808,7 +810,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureTouchDiagonal) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -834,7 +836,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureTouchLongStop) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -862,7 +864,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureTouchFling) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -888,7 +890,7 @@ TEST_P(SyntheticGestureControllerTestWithParam, scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -908,7 +910,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureMouseVertical) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -928,7 +930,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureMouseHorizontal) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -948,7 +950,7 @@ TEST_F(SyntheticGestureControllerTest, SingleScrollGestureMouseDiagonal) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -969,7 +971,7 @@ TEST_F(SyntheticGestureControllerTest, MultiScrollGestureMouse) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -991,7 +993,7 @@ TEST_F(SyntheticGestureControllerTest, MultiScrollGestureMouseHorizontal) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -1037,7 +1039,7 @@ TEST_F(SyntheticGestureControllerTest, MultiScrollGestureTouch) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -1065,7 +1067,7 @@ TEST_P(SyntheticGestureControllerTestWithParam, scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* scroll_target = @@ -1102,7 +1104,7 @@ TEST_F(SyntheticGestureControllerTest, SingleDragGestureMouseDiagonal) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* drag_target = @@ -1122,7 +1124,7 @@ TEST_F(SyntheticGestureControllerTest, SingleDragGestureMouseZeroDistance) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* drag_target = @@ -1143,7 +1145,7 @@ TEST_F(SyntheticGestureControllerTest, MultiDragGestureMouse) { scoped_ptr<SyntheticSmoothMoveGesture> gesture( new SyntheticSmoothMoveGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockMoveGestureTarget* drag_target = @@ -1225,7 +1227,7 @@ TEST_F(SyntheticGestureControllerTest, scoped_ptr<SyntheticTouchscreenPinchGesture> gesture( new SyntheticTouchscreenPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchscreenPinchTouchTarget* pinch_target = @@ -1248,7 +1250,7 @@ TEST_F(SyntheticGestureControllerTest, scoped_ptr<SyntheticTouchscreenPinchGesture> gesture( new SyntheticTouchscreenPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchscreenPinchTouchTarget* pinch_target = @@ -1270,7 +1272,7 @@ TEST_F(SyntheticGestureControllerTest, scoped_ptr<SyntheticTouchscreenPinchGesture> gesture( new SyntheticTouchscreenPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchscreenPinchTouchTarget* pinch_target = @@ -1292,7 +1294,7 @@ TEST_F(SyntheticGestureControllerTest, TouchpadPinchGestureTouchZoomIn) { scoped_ptr<SyntheticTouchpadPinchGesture> gesture( new SyntheticTouchpadPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchpadPinchTouchTarget* pinch_target = @@ -1314,7 +1316,7 @@ TEST_F(SyntheticGestureControllerTest, TouchpadPinchGestureTouchZoomOut) { scoped_ptr<SyntheticTouchpadPinchGesture> gesture( new SyntheticTouchpadPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchpadPinchTouchTarget* pinch_target = @@ -1335,7 +1337,7 @@ TEST_F(SyntheticGestureControllerTest, TouchpadPinchGestureTouchNoScaling) { scoped_ptr<SyntheticTouchpadPinchGesture> gesture( new SyntheticTouchpadPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTouchpadPinchTouchTarget* pinch_target = @@ -1358,7 +1360,7 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureExplicitTouch) { params.anchor.SetPoint(54, 89); scoped_ptr<SyntheticPinchGesture> gesture(new SyntheticPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); // Gesture target will fail expectations if the wrong underlying @@ -1376,7 +1378,7 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureExplicitMouse) { params.anchor.SetPoint(54, 89); scoped_ptr<SyntheticPinchGesture> gesture(new SyntheticPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); // Gesture target will fail expectations if the wrong underlying @@ -1394,7 +1396,7 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureDefaultTouch) { params.anchor.SetPoint(54, 89); scoped_ptr<SyntheticPinchGesture> gesture(new SyntheticPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); // Gesture target will fail expectations if the wrong underlying @@ -1412,7 +1414,7 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureDefaultMouse) { params.anchor.SetPoint(54, 89); scoped_ptr<SyntheticPinchGesture> gesture(new SyntheticPinchGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); // Gesture target will fail expectations if the wrong underlying @@ -1428,7 +1430,7 @@ TEST_F(SyntheticGestureControllerTest, TapGestureTouch) { params.position.SetPoint(87, -124); scoped_ptr<SyntheticTapGesture> gesture(new SyntheticTapGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTapTouchTarget* tap_target = @@ -1451,7 +1453,7 @@ TEST_F(SyntheticGestureControllerTest, TapGestureMouse) { params.position.SetPoint(98, 123); scoped_ptr<SyntheticTapGesture> gesture(new SyntheticTapGesture(params)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticTapMouseTarget* tap_target = @@ -1474,7 +1476,7 @@ TEST_F(SyntheticGestureControllerTest, PointerTouchAction) { scoped_ptr<SyntheticPointerAction> gesture(new SyntheticPointerAction( SyntheticGestureParams::TOUCH_INPUT, SyntheticGesture::PRESS, &synthetic_pointer, position)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); MockSyntheticPointerTouchActionTarget* pointer_touch_target = @@ -1488,7 +1490,7 @@ TEST_F(SyntheticGestureControllerTest, PointerTouchAction) { gesture.reset(new SyntheticPointerAction(SyntheticGestureParams::TOUCH_INPUT, SyntheticGesture::PRESS, &synthetic_pointer, position)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); pointer_touch_target = @@ -1504,7 +1506,7 @@ TEST_F(SyntheticGestureControllerTest, PointerTouchAction) { gesture.reset(new SyntheticPointerAction( SyntheticGestureParams::TOUCH_INPUT, SyntheticGesture::MOVE, &synthetic_pointer, position, index)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); pointer_touch_target = @@ -1517,7 +1519,7 @@ TEST_F(SyntheticGestureControllerTest, PointerTouchAction) { gesture.reset(new SyntheticPointerAction( SyntheticGestureParams::TOUCH_INPUT, SyntheticGesture::RELEASE, &synthetic_pointer, position, index)); - QueueSyntheticGesture(gesture.Pass()); + QueueSyntheticGesture(std::move(gesture)); FlushInputUntilComplete(); pointer_touch_target = |