Reorganize media::VideoCapture* types

The purpose of this CL is to clean up the distinction between
VideoCaptureFormat (which identifies the captured type of a frame),
VideoCaptureParams (which identifies the requested format of a capture),
and VideoCaptureCapability (which identifies the capture capabilities of a
device).

Notably:
* VideoCaptureFormat::frame_size_type ->
  VideoCaptureParams::allow_resolution_change, as variable resolution
  capability is a per-session, not a per-frame property.
* VideoCaptureCapability::color -> VideoCaptureFormat::pixel_format, as frame
  color format is a per-frame property.
  * As VideoCaptureParams holds a VideoCaptureFormat member, capture requests
    are able now to request a particular capture color format.

BUG=269312
TEST=local build, run unittests, chrome on CrOS snow, desktop Linux

Review URL: https://codereview.chromium.org/68503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236927 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 14 deletions

diff --git a/content/browser/renderer_host/media/video_capture_host_unittest.cc b/content/browser/renderer_host/media/video_capture_host_unittest.cc
index cdb465b..43a9d8d 100644
--- a/content/browser/renderer_host/media/video_capture_host_unittest.cc
+++ b/content/browser/renderer_host/media/video_capture_host_unittest.cc
@@ -199,13 +199,14 @@ class MockVideoCaptureHost : public VideoCaptureHost {
     ASSERT_TRUE(dib != NULL);
     if (dump_video_) {
       if (!format_.IsValid()) {
-        dumper_.StartDump(frame_format.width, frame_format.height);
+        dumper_.StartDump(frame_format.frame_size.width(),
+                          frame_format.frame_size.height());
         format_ = frame_format;
       }
-      ASSERT_EQ(format_.width, frame_format.width)
+      ASSERT_EQ(format_.frame_size.width(), frame_format.frame_size.width())
+          << "Dump format does not handle variable resolution.";
+      ASSERT_EQ(format_.frame_size.height(), frame_format.frame_size.height())
           << "Dump format does not handle variable resolution.";
-      ASSERT_EQ(format_.height, frame_format.height)
-          << "Dump format does not handle variable resolution.";;
       dumper_.NewVideoFrame(dib->memory());
     }
 
@@ -347,9 +348,8 @@ class VideoCaptureHostTest : public testing::Test {
 
     media::VideoCaptureParams params;
     params.requested_format = media::VideoCaptureFormat(
-        352, 288, 30, media::ConstantResolutionVideoCaptureDevice);
-    params.session_id = opened_session_id_;
-    host_->OnStartCapture(kDeviceId, params);
+        gfx::Size(352, 288), 30, media::PIXEL_FORMAT_I420);
+    host_->OnStartCapture(kDeviceId, opened_session_id_, params);
     run_loop.Run();
   }
 
@@ -361,9 +361,8 @@ class VideoCaptureHostTest : public testing::Test {
     EXPECT_CALL(*host_, OnStateChanged(kDeviceId, VIDEO_CAPTURE_STATE_STOPPED));
     media::VideoCaptureParams params;
     params.requested_format = media::VideoCaptureFormat(
-        352, 288, 30, media::ConstantResolutionVideoCaptureDevice);
-    params.session_id = opened_session_id_;
-    host_->OnStartCapture(kDeviceId, params);
+        gfx::Size(352, 288), 30, media::PIXEL_FORMAT_I420);
+    host_->OnStartCapture(kDeviceId, opened_session_id_, params);
     host_->OnStopCapture(kDeviceId);
     run_loop.RunUntilIdle();
   }
@@ -380,11 +379,10 @@ class VideoCaptureHostTest : public testing::Test {
         .WillOnce(ExitMessageLoop(message_loop_, run_loop.QuitClosure()));
 
     media::VideoCaptureParams params;
-    params.requested_format = media::VideoCaptureFormat(
-        width, height, frame_rate, media::ConstantResolutionVideoCaptureDevice);
-    params.session_id = opened_session_id_;
+    params.requested_format =
+        media::VideoCaptureFormat(gfx::Size(width, height), frame_rate);
     host_->SetDumpVideo(true);
-    host_->OnStartCapture(kDeviceId, params);
+    host_->OnStartCapture(kDeviceId, opened_session_id_, params);
     run_loop.Run();
   }
 #endif