diff options
| author | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-30 05:47:34 +0000 |
|---|---|---|
| committer | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-30 05:47:34 +0000 |
| commit | 678e136687693d38e647c2795a909967a01ec014 (patch) | |
| tree | a96e5b22bba08946cb01972442679d2ef727a5b3 /content/browser/renderer_host/render_widget_host_view_android.h | |
| parent | d38a41f48cf338a1c74d58f883fc738d60fdaeae (diff) | |
| download | chromium_src-678e136687693d38e647c2795a909967a01ec014.zip chromium_src-678e136687693d38e647c2795a909967a01ec014.tar.gz chromium_src-678e136687693d38e647c2795a909967a01ec014.tar.bz2 | |
RWHI should implement BrowserAccessibilityDelegate
This is just refactoring, there should be no behavior changes.
I realized that most of the functionality of
BrowserAccessibilityDelegate was implemented by
RenderWidgetHostImpl, but each RenderWidgetHostView*
was actually implementing the interface, resulting in
extra code. It's simpler to have RWHI implement it and
just call into RWHV for the few cases where the view is
involved.
This also removes the parallel mac-only delegate, since
it was duplicating most of the same functionality.
Calling OriginInScreen is a couple of extra lines of code
because it needs to convert from NSPoint & NSSize to
gfx::Rect, but in every other case it's the same or simpler
this way.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/246773008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267097 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/renderer_host/render_widget_host_view_android.h')
| -rw-r--r-- | content/browser/renderer_host/render_widget_host_view_android.h | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h index fc38ca0..f64df79 100644 --- a/content/browser/renderer_host/render_widget_host_view_android.h +++ b/content/browser/renderer_host/render_widget_host_view_android.h @@ -60,7 +60,6 @@ struct NativeWebKeyboardEvent; // ----------------------------------------------------------------------------- class RenderWidgetHostViewAndroid : public RenderWidgetHostViewBase, - public BrowserAccessibilityDelegate, public cc::DelegatedFrameResourceCollectionClient, public ImageTransportFactoryAndroidObserver, public ui::GestureProviderClient, @@ -169,18 +168,6 @@ class RenderWidgetHostViewAndroid virtual void LockCompositingSurface() OVERRIDE; virtual void UnlockCompositingSurface() OVERRIDE; - // Implementation of BrowserAccessibilityDelegate: - virtual void SetAccessibilityFocus(int acc_obj_id) OVERRIDE; - virtual void AccessibilityDoDefaultAction(int acc_obj_id) OVERRIDE; - virtual void AccessibilityScrollToMakeVisible( - int acc_obj_id, gfx::Rect subfocus) OVERRIDE; - virtual void AccessibilityScrollToPoint( - int acc_obj_id, gfx::Point point) OVERRIDE; - virtual void AccessibilitySetTextSelection( - int acc_obj_id, int start_offset, int end_offset) OVERRIDE; - virtual gfx::Point GetLastTouchEventLocation() const OVERRIDE; - virtual void FatalAccessibilityTreeError() OVERRIDE; - // cc::DelegatedFrameResourceCollectionClient implementation. virtual void UnusedResourcesAreAvailable() OVERRIDE; |