diff options
| author | tapted <tapted@chromium.org> | 2014-09-29 21:19:06 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-30 04:19:28 +0000 |
| commit | 7e0b5922f9c88d1a733bf95c084c9f1646a8777e (patch) | |
| tree | 18866d74db334ab1bf0dbafdf49d72811c047814 /content/browser/renderer_host/render_widget_host_view_base.cc | |
| parent | 2636d976fb583560c0817dc258a9e37578501bec (diff) | |
| download | chromium_src-7e0b5922f9c88d1a733bf95c084c9f1646a8777e.zip chromium_src-7e0b5922f9c88d1a733bf95c084c9f1646a8777e.tar.gz chromium_src-7e0b5922f9c88d1a733bf95c084c9f1646a8777e.tar.bz2 | |
Remove #ifdefs around ShowLinkDisambiguationPopup
Current efforts are aimed at harmonizing our UI code. #ifdefs work
against this and have a lot of downsides besides.
This is a follow-up to http://crrev.com/351683002 -- a long-running CL
which added ShowLinkDisambiguationPopup to Aura -- and
http://crrev.com/596373002 which fixed some build problems with that.
However, toolkit_views=1 use_aura=0 which is in use on Mac still has
problems.
This CL adds default method definitions to WebContentsViewDelegate and
RenderWidgetHostViewBase. Essentially moving a NOTIMPLEMENTED() guarded
by #ifdefs into a base class method, and removing some unnecessary
boilerplate.
BUG=385249, 399191
Review URL: https://codereview.chromium.org/610893003
Cr-Commit-Position: refs/heads/master@{#297360}
Diffstat (limited to 'content/browser/renderer_host/render_widget_host_view_base.cc')
| -rw-r--r-- | content/browser/renderer_host/render_widget_host_view_base.cc | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc index 51fd023..fcd41f0 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.cc +++ b/content/browser/renderer_host/render_widget_host_view_base.cc @@ -605,6 +605,19 @@ SkColorType RenderWidgetHostViewBase::PreferredReadbackFormat() { return kN32_SkColorType; } +void RenderWidgetHostViewBase::OnTextSurroundingSelectionResponse( + const base::string16& content, + size_t start_offset, + size_t end_offset) { + NOTIMPLEMENTED(); +} + +void RenderWidgetHostViewBase::ShowDisambiguationPopup( + const gfx::Rect& rect_pixels, + const SkBitmap& zoomed_bitmap) { + NOTIMPLEMENTED(); +} + gfx::Size RenderWidgetHostViewBase::GetVisibleViewportSize() const { return GetViewBounds().size(); } |