diff options
| author | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-18 16:00:43 +0000 |
|---|---|---|
| committer | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-18 16:00:43 +0000 |
| commit | d6fa88f5c6c8e835260bb05db880b463ea941626 (patch) | |
| tree | bba43b0726890cd2358351e67a023b2f7ac6715b /content/browser/renderer_host/render_widget_host_view_mac.mm | |
| parent | d2d5bdff707333ed9ae5e1492354746513ba229d (diff) | |
| download | chromium_src-d6fa88f5c6c8e835260bb05db880b463ea941626.zip chromium_src-d6fa88f5c6c8e835260bb05db880b463ea941626.tar.gz chromium_src-d6fa88f5c6c8e835260bb05db880b463ea941626.tar.bz2 | |
Set is_hidden bit for background navigations
r218548 added an initial visibility state for WebContentsImpls and RenderWidgetHost(View|Impl)s and set it for cross-process navigations, but failed to set the correct initial state for in-process navigations. This propagates the initial hidden state correctly in these places:
1.) For browser navigations, this propagates the WebContents::CreateParams::initially_hidden bit into WebContentsImpl. Previously this went nowhere (oops!)
2.) For window.open() navigations to background tabs, this initializes the RenderViewImpl's hidden bit based on the navigation disposition.
3.) For RenderWidgetHostView impls that store their own is_hidden bit (mac, gtk and guest) this sets the initial state correctly based off of the RenderWidgetHostImpl. The other RWHView implementations do not store their own is_hidden bool and just ask their RenderWidgetHostImpl for the bit. I'm not sure why this is.
BUG=305437, 302574
TEST=see bug
R=jam@chromium.org
Review URL: https://codereview.chromium.org/27203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229428 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/renderer_host/render_widget_host_view_mac.mm')
| -rw-r--r-- | content/browser/renderer_host/render_widget_host_view_mac.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm index fd86a23..70091a1 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -423,7 +423,7 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget) allow_overlapping_views_(false), use_core_animation_(false), is_loading_(false), - is_hidden_(false), + is_hidden_(render_widget_host_->is_hidden()), weak_factory_(this), fullscreen_parent_host_view_(NULL), pending_swap_buffers_acks_weak_factory_(this), |